Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Open customize.xul as a resizable window. Fixes #55. #79

Merged
merged 1 commit into from

2 participants

@xabolcs
Owner

Also set it's dimensions to 3:2.

As I know, it applies almost cleanly to top of #74.

@whimboo
Owner

Why does it need pull #74 merged first? I don't see why. Otherwise it looks good, but not tested yet.

@xabolcs
Owner

whimbo commented

Why does it need pull #74 merged first? I don't see why. ...

I just wanted to note that these pulls (#55, #74) are independent from each other,
and the "merger" person is free to choice what to land first. :)

@whimboo
Owner

Looks good. Pushed:
05ae130

@whimboo whimboo closed this
@xabolcs
Owner

I thought that I would be the author. :'(

@whimboo whimboo reopened this
@whimboo whimboo merged commit b19d86f into mozilla:master
@whimboo
Owner

Sorry, something went wrong with the merge. Should be fixed now.

@whimboo
Owner

Is github broken? I'm still the author of this patch!?

@xabolcs
Owner

whimboo commented

Is github broken? I'm still the author of this patch!?

The reverted 05ae130 is still yours, but my commit is in the tree now too. :)
Thanks!

@whimboo
Owner

Wait. The merge commit is from myself but the actual code landing is yours. Solved! :) Sorry again.

@xabolcs xabolcs commented on the diff
extension/chrome/content/titlebar/customize.xul
@@ -41,9 +41,10 @@
<prefwindow id="NightlyTesterOptions" windowtype="NightlyTester:Customize"
title="&nightly.customize.title;"
+ style="width: 42.75em; height: 28.5em" persist="width height"
@xabolcs Owner
xabolcs added a note

#74 (re)introduces titlebar.css. If that pull lands, move this styling there!

@whimboo Owner
whimboo added a note

Has this already been moved over?

@xabolcs Owner
xabolcs added a note

whimboo commented on commit:

Has this already been moved over?

Yes! I did take care about this in ba06511 and 66c0392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 3, 2012
  1. @xabolcs

    Issue #55 - open customize.xul as a resizable window.

    xabolcs authored
    Also set it's dimensions to 3:2.
This page is out of date. Refresh to see the latest.
View
4 extension/chrome/content/nightly.js
@@ -455,10 +455,10 @@ openCustomize: function() {
var prefservice = Components.classes["@mozilla.org/preferences-service;1"]
.getService(Components.interfaces.nsIPrefBranch);
var instantApply = prefservice.getBoolPref("browser.preferences.instantApply");
- features = "chrome,titlebar,toolbar,centerscreen" + (instantApply ? ",dialog=no" : ",modal");
+ features = "chrome,titlebar,toolbar,centerscreen,resizable" + (instantApply ? ",dialog=no" : ",modal");
}
catch (e) {
- features = "chrome,titlebar,toolbar,centerscreen,modal";
+ features = "chrome,titlebar,toolbar,centerscreen,resizable,modal";
}
openDialog("chrome://nightly/content/titlebar/customize.xul", "", features);
},
View
3  extension/chrome/content/titlebar/customize.xul
@@ -41,9 +41,10 @@
<prefwindow id="NightlyTesterOptions" windowtype="NightlyTester:Customize"
title="&nightly.customize.title;"
+ style="width: 42.75em; height: 28.5em" persist="width height"
@xabolcs Owner
xabolcs added a note

#74 (re)introduces titlebar.css. If that pull lands, move this styling there!

@whimboo Owner
whimboo added a note

Has this already been moved over?

@xabolcs Owner
xabolcs added a note

whimboo commented on commit:

Has this already been moved over?

Yes! I did take care about this in ba06511 and 66c0392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
- <prefpane id="paneTitle" label="&nightly.customize.title;">
+ <prefpane id="paneTitle" label="&nightly.customize.title;" flex="1">
<preferences>
<preference id="idtitle" type="bool" name="nightly.idtitle" onchange="paneTitle.toggled();"/>
Something went wrong with that request. Please try again.