Prepare to release version 3.4. Helps to fix Issue #95. #97

Closed
wants to merge 6 commits into
from

Projects

None yet

3 participants

@xabolcs
Collaborator
xabolcs commented Oct 11, 2012

Hi!

Please do not stash the 3.5pre version bump commit with the others!
Merge this pull request as 2 commit: one for the release notes and one for version bump.

There should be a commit where the <version> is 3.4 in install.rdf!
That commit should be tagged as v3.4!

Release Notes contains:

  • Include changeset info in the Insert/Copy Build ID menuitem and in 'Customize Titlebar'. Issue #65 / Pull #73.
  • Add pushlog-to-tip menuitem. Issue #61 / Pull #75.
  • Open customize.xul (Customize Titlebar) as a resizable window. Issue #55 / Pull #79.
  • Let nightlyApp.openNotification() fallback to notificationBox in legacy Fx. Issue #81 / Pull #83.
  • Include about:nightly in Nightly Tester Tools' menupopup for Thunderbird. #56 / Pull #76.
  • Don't call callback function when iterating over Extension Manager's extensions list. Issue #88 / Pull #89.
  • Don't register aboutNightly component for 'profile-after-change' notification. Issue #57 / Pull #77.
  • Update 'Contributors' section automatically in about:nightly. Issue #58 / Pull #85.
  • Move to MPL2. Issue #39 / Pull #96, #98.
  • Column resizing in 'Customize Titlebar' window. Issue #25 / Pull #74.
  • Add privacy context to saveScreenshot() due to Bug 795065. Issue #99 / Pull #102.
  • Update checkCompatibility preferences for compatibility. Pull #103.
  • Use GreD instead CurProcD to reference GRE specific files. Issue #115 / Pull #116.

Nice to have (but not blocking!) fixes (in priority order):

  • Broken upload APIs: screenshot (Issue #49 / Pull #84) and about:support (Issue #86 / Pull #93)
  • ... and the others ;)

Please note that the issue numbers in the commit are the issue numbers instead pull numbers!

AMO Release Notes strings:

Built from <a href="https://github.com/mozilla/nightlytt/commit/99f1679e01fc"><code>99f1679e01fc</code></a>.
<ul>
  <li>Extension: Use GreD instead CurProcD to reference GRE specific files. (<a href="https://github.com/mozilla/nightlytt/issues/115">#115</a>)</li>
  <li>Extension: Update checkCompatibility preferences for compatibility. (<a href="https://github.com/mozilla/nightlytt/issues/103">#103</a>)</li>
  <li>Extension: Add privacy context to <code>saveScreenshot()</code> due to <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=795065">Bug 795065</a>. (<a href="https://github.com/mozilla/nightlytt/issues/99">#99</a>)</li>
  <li>Extension: Make columns of 'Customize Titlebar' dialog's tree resizable. (<a href="https://github.com/mozilla/nightlytt/issues/25">#25</a>)</li>
  <li>Extension: Re-license under MPL2. (<a href="https://github.com/mozilla/nightlytt/issues/39">#39</a>, <a href="https://github.com/mozilla/nightlytt/issues/98">#98</a>)</li>
  <li>Extension: Update 'Contributors' section automatically in about:nightly. (<a href="https://github.com/mozilla/nightlytt/issues/58">#58</a>)</li>
  <li>Extension: Don't register aboutNightly component for 'profile-after-change' notification. (<a href="https://github.com/mozilla/nightlytt/issues/57">#57</a>)</li>
  <li>Extension: Don't call callback function when iterating over Extension Manager's extensions list. (<a href="https://github.com/mozilla/nightlytt/issues/88">#88</a>)</li>
  <li>Extension: Include about:nightly in Nightly Tester Tools' menupopup for Thunderbird. (<a href="https://github.com/mozilla/nightlytt/issues/56">#56</a>)</li>
  <li>Extension: Let <code>nightlyApp.openNotification()</code> fallback to notificationBox in legacy Fx. (<a href="https://github.com/mozilla/nightlytt/issues/81">#81</a>)</li>
  <li>Extension: Open customize.xul (Customize Titlebar)</li> as a resizable window. (<a href="https://github.com/mozilla/nightlytt/issues/55">#55</a>)</li>
  <li>Extension: Add pushlog-to-tip menuitem. (<a href="https://github.com/mozilla/nightlytt/issues/61">#61</a>)</li>
  <li>Extension: Include changeset info in the Insert/Copy Build ID menuitem and in 'Customize Titlebar'. (<a href="https://github.com/mozilla/nightlytt/issues/65">#65</a>)</li>
</ul>

Details are on <a href="https://github.com/mozilla/nightlytt/compare/v3.3...v3.4">GitHub</a>.
@whimboo
Collaborator
whimboo commented Oct 17, 2012

Please remove the commit for the 3.5pre version bump. That will be done separately and is not part of this task.

@whimboo whimboo and 1 other commented on an outdated diff Oct 17, 2012
@@ -1,3 +1,15 @@
+3.4 / 2012-10-11
+==================
+
+ * Extension: Include changeset info in the Insert/Copy Build ID menuitem and in 'Customize Titlebar'. (#65)
@whimboo
whimboo Oct 17, 2012 Collaborator

Please use the pull # instead of the issue #. Reason is that we have to be consistent and check-ins will have a pull but not necessarily an issue.

@xabolcs
xabolcs Oct 19, 2012 Collaborator

I vote for __Issue Number__s, because they are more descriptive, they are the goal, the drivers of development.
Pulls are tools of controlling - how the changes are accepted and merged into source.

Of course Pull Number is OK, when no Issue Number exists.

Other way of reasoning:
Pulls are closer to compare view (e.g. v3.2.2...v3.3), and issues are closer to milestones.
And release notes (history.md) are closer to milestones, IMHO.

@xabolcs
xabolcs Oct 30, 2012 Collaborator

For another example see mozmill!

It's official repository is on GitHub, but it's tracker is bugzilla.mozilla.org.
Check the it's changelists on AMO, it uses bug numbers instead of pull numbers!
(The commit messages refers to bug numbers also - but this is not the subject here)

As I noted in my previous comment, the issue numbers are more informative than the pull request numbers.

@whimboo whimboo commented on the diff Oct 17, 2012
extension/install.rdf
@@ -63,7 +63,7 @@
<Description>
<em:id>songbird@songbirdnest.com</em:id>
<em:minVersion>1.6</em:minVersion>
- <em:maxVersion>1.12.0a</em:maxVersion>
+ <em:maxVersion>2.2.0a</em:maxVersion>
@whimboo
whimboo Oct 17, 2012 Collaborator

Oh wow, a major version change. Do you know on which gecko branch this version is based on?

@xabolcs
xabolcs Oct 18, 2012 Collaborator

whimboo wrote:

Oh wow, a major version change. Do you know on which gecko branch this version is based on?

Regarding to application.ini.in and sbBuildInfo.mk.in it is based on Gecko 1.9.2.

[Gecko]
MinVersion=1.9.2
MaxVersion=1.9.2.*
@whimboo
whimboo Oct 18, 2012 Collaborator

Damn. I was really hoping they get off from this gecko branch. :(

@xabolcs
xabolcs Oct 18, 2012 Collaborator

whimboo wrote:

Damn. ...

I happily do the needed extra maintenance work. :)

@xabolcs
Collaborator
xabolcs commented Oct 18, 2012

If 3.4 going to be released without the Force compatibility enhancement (Issue #52 / Pull #82) then a version-string update to nttAddonCompatibilityService.js is really recommended!

@xabolcs
Collaborator
xabolcs commented Oct 18, 2012

Updated description due to landings:

  • Move to MPL2. Issue #39 / Pull #96. 👍
  • Column resizing in 'Customize Titlebar' window. Issue #25 / Pull #74. 👍
@xabolcs
Collaborator
xabolcs commented Oct 19, 2012

Updated description due to removed commit 0a16d69:

  • deleted no stash please
@xabolcs xabolcs Issue #95 - update part 1:
- MPL 2 landed
- column resize landed
7260099
@xabolcs
Collaborator
xabolcs commented Oct 25, 2012

Updated commit range (including 7260099):

  • history.md updates

Still using Issue Numbers because @whimboo didn't give a feedback to my comments.

@xabolcs
Collaborator
xabolcs commented Oct 25, 2012

xabolcs commented:

If 3.4 going to be released without the Force compatibility enhancement (Issue #52 / Pull #82) then a version-string update to nttAddonCompatibilityService.js is really recommended!

Opened Pull #103.

@xabolcs
Collaborator
xabolcs commented Oct 25, 2012

Updated description:

  • removed xpis - they are now outdated
@xabolcs xabolcs Issue #95 - update part 2:
- privacyContext'ed screenshot landed
7033509
@xabolcs
Collaborator
xabolcs commented Oct 26, 2012

Updated description & commit range due to landings:

  • Add privacy context to saveScreenshot() due to Bug 795065. Issue #99 / Pull #102.
@xabolcs
Collaborator
xabolcs commented Oct 30, 2012

Should I provide here (for example in the description) AMO formatted Release Notes to avoid Markdown formatted strings being used on AMO?

@tonymec
Collaborator
tonymec commented Oct 31, 2012

IIUC one pull may refer to zero, one, two… issues. I agree that the issue number(s) are more meaningful than the pull number (on hg.mozilla.org, each commit has either a bug number or NO BUG) but why not mention the pull number and also all the issues it fixes (or helps to fix)?

@xabolcs
Collaborator
xabolcs commented Oct 31, 2012

I agree with tonymec.

tonymec wrote:

... but why not mention the pull number and also all the issues it fixes (or helps to fix)?

For example see my comment on mozillaZine:

The extras are:

  • Bug 726560 - Add support of Panorama group name (FF10+) for titlebar customization. Pull #19.
  • Convert 'Customize Titlebar' dialog's listbox into tree, and make it's columns resizable. Fixes #25. Pull #74.
  • Implement new upload providers for screenshot. Fixes #49. Pull #84.
  • Use pastebin.m.o with FormData where applicable. Fixes #86. Pull #93.
  • Revamp NTT's force-compatiblity feature. Fixes #52. Pull #82.

Another example is the desctiption:

Release Notes contains:

  • Include changeset info in the Insert/Copy Build ID menuitem and in 'Customize Titlebar'. Issue #65 / Pull #73.
  • Add pushlog-to-tip menuitem. Issue #61 / Pull #75.
  • Open customize.xul (Customize Titlebar) as a resizable window. Issue #55 / Pull #79.
  • Let nightlyApp.openNotification() fallback to notificationBox in legacy Fx. Issue #81 / Pull #83.
  • Include about:nightly in Nightly Tester Tools' menupopup for Thunderbird. #56 / Pull #76.
  • Don't call callback function when iterating over Extension Manager's extensions list. Issue #88 / Pull #89.
  • Don't register aboutNightly component for 'profile-after-change' notification. Issue #57 / Pull #77.
  • Update 'Contributors' section automatically in about:nightly. Issue #58 / Pull #85.
  • Move to MPL2. Issue #39 / Pull #96, #98.
  • Column resizing in 'Customize Titlebar' window. Issue #25 / Pull #74.
  • Add privacy context to saveScreenshot() due to Bug 795065. Issue #99 / Pull #102.
@xabolcs xabolcs Issue #95 - update part 3:
- 'extensions.checkCompatibility' updated
99f1679
@xabolcs
Collaborator
xabolcs commented Nov 3, 2012

Updated description & commit range due to landing:

  • Update checkCompatibility preferences for compatibility. Pull #103.
  • AMO strings into description
@whimboo
Collaborator
whimboo commented Nov 6, 2012

Ok, we further discussed this and @davehunt also agrees on using the issue # instead. @xabolcs would you mind to update the pull and replace all # with the issue #?

@xabolcs
Collaborator
xabolcs commented Nov 6, 2012

Thanks!

Currently almost all the numbers are issue #. Only titlebar.css MPL2 (#98, related to issue #39) and checkCompatibility bump (#103, related to release work, issue #95) are pull #, because there was no needed to open a separate issue for them.

Also the AMO strings are using issue #s (where exists, and the issue -> pull redirect does work).

I think the pull request is up to date in the term of numbers.
And it's based on commit 788d3fc.
(Of course update will be necessary if other fixes land. :) )

Should I do other changes or checks?

@whimboo
Collaborator
whimboo commented Nov 6, 2012

Given that you have the best overview of pull requests at the moment it would be good to know which ones you would like to see in 3.4. How many remain before we can release the next version?

@xabolcs
Collaborator
xabolcs commented Nov 6, 2012

Nice to have pulls:

  • Pull #104 - health: OK, complexity: moderate (see it's description)
  • Pull #93 - health: need info from You, complexity: low (because you've reviewed it at least once)
  • Pull #84 - health: need info from You + optional cleanup, complexity: low (trivial changes)
@xabolcs
Collaborator
xabolcs commented Jan 30, 2013

@whimboo
Do you allow me to merge this pull, pack NTT 3.4 in it's current state into xpi
and ask somebody (@tonymec? :)) to upload that file to AMO?
Do you agree with the above?

Please drop a line!

@whimboo
Collaborator
whimboo commented Feb 18, 2013

Sorry for the late reply but I was on vacation for a while. So with the latest fix from #115 landed we should get out a new version of NTT as soon as possible. Would you mind to update this pull so we can get this version released?

@xabolcs xabolcs Issue #95 - update part 4:
- GreD/CurProcD workaround for Bug 755724
892eaf4
@xabolcs
Collaborator
xabolcs commented Feb 18, 2013

@whimboo

Just updated the commit range to include the updated changelist + release date.
I updated the AMO Release Notes strings section in the description of this pull. Feel free to use that on AMO!

Let 3.4 go! :)

@whimboo whimboo commented on an outdated diff Feb 19, 2013
+3.4 / 2013-02-18
+==================
+
+ * Extension: Include changeset info in the Insert/Copy Build ID menuitem and in 'Customize Titlebar'. (#65)
+ * Extension: Add pushlog-to-tip menuitem. (#61)
+ * Extension: Open customize.xul (Customize Titlebar) as a resizable window. (#55)
+ * Extension: Let nightlyApp.openNotification() fallback to notificationBox in legacy Fx. (#81)
+ * Extension: Include about:nightly in Nightly Tester Tools' menupopup for Thunderbird. (#56)
+ * Extension: Don't call callback function when iterating over Extension Manager's extensions list. (#88)
+ * Extension: Don't register aboutNightly component for 'profile-after-change' notification. (#57)
+ * Extension: Update 'Contributors' section automatically in about:nightly. (#58)
+ * Extension: Re-license under MPL2. (#39, #98)
+ * Extension: Make columns of 'Customize Titlebar' dialog's tree resizable. (#25)
+ * Extension: Add privacy context to saveScreenshot() due to Bug 795065. (#99)
+ * Extension: Update checkCompatibility preferences for compatibility. (#103)
+ * Extension: Use GreD instead CurProcD to reference GRE specific files. (#115)
@whimboo
whimboo Feb 19, 2013 Collaborator

The order of the items look incorrect. We usually sort descending with the most recent fix at the top. Can you please fix that?

@whimboo whimboo commented on an outdated diff Feb 19, 2013
@@ -1,3 +1,20 @@
+3.4 / 2013-02-18
@whimboo
whimboo Feb 19, 2013 Collaborator

Can we bump the date for today?

@whimboo whimboo and 1 other commented on an outdated diff Feb 19, 2013
extension/install.rdf
@@ -36,7 +36,7 @@
<Description>
<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
<em:minVersion>3.6</em:minVersion>
- <em:maxVersion>15.0a1</em:maxVersion>
+ <em:maxVersion>19.0a1</em:maxVersion>
@whimboo
whimboo Feb 19, 2013 Collaborator

Meanwhile we have 21.0a1. You might want to update the other versions too.

@xabolcs
xabolcs Feb 19, 2013 Collaborator

Fx 22's release date is 2013-02-19. What about updating maxVersion to 22.0a1 instead?

@whimboo
whimboo Feb 19, 2013 Collaborator

Oh yes, please do so. Totally missed that. :)

@xabolcs xabolcs Issue #95 - update part 5:
- reverse changelist
- maxVersion
1468566
@xabolcs
Collaborator
xabolcs commented Feb 19, 2013

@whimboo
Updated commit range, updated description (for AMO strings)

@whimboo
Collaborator
whimboo commented Feb 19, 2013
@whimboo whimboo closed this Feb 19, 2013
@xabolcs xabolcs deleted the xabolcs:branch-issue-95-release-ntt-version-3.4 branch Feb 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment