Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improoved HSTS support #26

Merged
merged 5 commits into from Sep 24, 2014

Conversation

Projects
None yet
2 participants
Contributor

J0WI commented May 27, 2014

bug 901909
bug 946705
bug 946697
Updated all links to https

J0WI added some commits May 27, 2014

Fix bug 901909
Change Download links from http to https on nightly.mozilla.org
Update index.html
See bug 946705, bug 946697 
Updated URLS to https
Corrected Facebook URL

@tofumatt tofumatt commented on an outdated diff May 27, 2014

templates/index.html
_gaq.push(['_trackPageview']);
(function() {
var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
- ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
@tofumatt

tofumatt May 27, 2014

Member

Why change the GA code? You can still access http://nightly.mozilla.org, so this could break.

@tofumatt

tofumatt May 27, 2014

Member

Until https://bugzilla.mozilla.org/show_bug.cgi?id=946697 is resolved, I can't merge this in; don't want to cause any regressions.

@tofumatt tofumatt commented on the diff May 27, 2014

templates/index.html
@@ -159,11 +159,12 @@
var _gaq = _gaq || [];
_gaq.push(['_setAccount', 'UA-35433268-45']);
+ _gaq.push (['_gat._anonymizeIp']);
@tofumatt

tofumatt May 27, 2014

Member

Is this something Mozilla does? cc @chrismore

@tofumatt

tofumatt May 27, 2014

Member

Just read the bug, seems the answer is yes.

Member

tofumatt commented May 27, 2014

r- until we hear back from https://bugzilla.mozilla.org/show_bug.cgi?id=946697. I'll leave this open but it shouldn't be merged in yet.

Contributor

J0WI commented Aug 29, 2014

tofumatt added a commit that referenced this pull request Sep 24, 2014

Merge pull request #26 from J0WI/master
Improoved HSTS support

@tofumatt tofumatt merged commit 1e909ea into mozilla:master Sep 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment