Permalink
Commits on Sep 21, 2018
  1. Merge #1551

    bors[bot] and peterbe committed Sep 21, 2018
    1551: print left-over print statement r=mythmon a=peterbe
    
    Fixes #1545
    
    Co-authored-by: Peter Bengtsson <mail@peterbe.com>
  2. print left-over print statement

    peterbe committed Sep 21, 2018
    Fixes #1545
  3. Merge #1549

    bors[bot] and mythmon committed Sep 21, 2018
    1549: docs: Explain filter object shape better r=peterbe a=mythmon
    
    
    
    Co-authored-by: Mike Cooper <mythmon@gmail.com>
  4. Typo and talk more about sampling

    mythmon committed Sep 21, 2018
Commits on Sep 20, 2018
  1. docs: Explain filter object shape better

    mythmon committed Sep 20, 2018
Commits on Sep 19, 2018
  1. Merge #1546

    bors[bot] and peterbe committed Sep 19, 2018
    1546: Move /api/v1/filters to /api/v3/filters r=mythmon a=peterbe
    
    Fixes #1545
    
    Co-authored-by: Peter Bengtsson <mail@peterbe.com>
  2. Merge #1541

    bors[bot] and renovate-bot committed Sep 19, 2018
    1541: Update babel monorepo to v7.1.0 r=mythmon a=renovate[bot]
    
    <p>This Pull Request renovates the package group "babel monorepo" with the following modifications:</p>
    <ul>
    <li>Updates devDependency <code>@babel/core</code> (<a href="https://babeljs.io/">homepage</a>, <a href="https://renovatebot.com/gh/babel/babel">source</a>) from <code>v7.0.1</code> to <code>v7.1.0</code></li>
    <li>Updates devDependency <code>@babel/plugin-proposal-class-properties</code> (<a href="https://renovatebot.com/gh/babel/babel">source</a>) from <code>v7.0.0</code> to <code>v7.1.0</code></li>
    <li>Updates devDependency <code>@babel/plugin-transform-modules-commonjs</code> (<a href="https://renovatebot.com/gh/babel/babel">source</a>) from <code>v7.0.0</code> to <code>v7.1.0</code></li>
    </ul>
    <h1 id="release-notes">Release Notes</h1>
    <p>
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
  3. Move /api/v1/filters to /api/v3/filters

    peterbe committed Sep 19, 2018
    Fixes #1545
Commits on Sep 18, 2018
  1. Merge #1542

    bors[bot] and mythmon committed Sep 18, 2018
    1542: Wait longer for karma server to be ready r=peterbe a=mythmon
    
    We theorized this wasn't a long enough timer, and CI has proven that correct.
    
    Co-authored-by: Mike Cooper <mythmon@gmail.com>
  2. Merge #1543

    bors[bot] and renovate-bot committed Sep 18, 2018
    1543: Update dependency webpack to v4.19.1 r=mythmon a=renovate[bot]
    
    <p>This Pull Request updates devDependency <code>webpack</code> (<a href="https://renovatebot.com/gh/webpack/webpack">source</a>) from <code>v4.19.0</code> to <code>v4.19.1</code></p>
    <p>
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
  3. Update dependency webpack to v4.19.1

    renovate-bot committed Sep 18, 2018
Commits on Sep 17, 2018
  1. Wait longer for karma server to be ready

    mythmon committed Sep 17, 2018
    We theorized this wasn't a long enough timer, and CI has proven that correct.
  2. Merge #1533

    bors[bot] and renovate-bot committed Sep 17, 2018
    1533: Update dependency karma-webpack to v3.0.5 r=mythmon a=renovate[bot]
    
    <p>This Pull Request updates devDependency <code>karma-webpack</code> (<a href="https://renovatebot.com/gh/webpack-contrib/karma-webpack">source</a>) from <code>v3.0.4</code> to <code>v3.0.5</code></p>
    <p>
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
  3. Update babel monorepo to v7.1.0

    renovate-bot committed Sep 17, 2018
  4. Update dependency karma-webpack to v3.0.5

    renovate-bot committed Sep 17, 2018
  5. Merge #1540

    bors[bot] and peterbe committed Sep 17, 2018
    1540: unit test untested checks r=mythmon a=peterbe
    
    Part of #1223
    
    This is a cheeky solution. One unit test to run them all in one big sweep. 
    
    At first I thought I'd do something like this:
    
    ```python
    def test_setting_cdn_url(settings):
        errors = checks.setting_cdn_url(None)
        assert something_about_errors
    ```
    
    but it would get tedious and we've accepted to live without unit tests for these things for a long time. 
    
    This PR will make sure every *registered* check is run in CI. It's not entirely different in philosophy from when we do...
    ```python
        def test_it_works(self):
            """
            Verify that the update_actions command doesn't throw an error.
            """
            call_command("update_actions")
    ```
    
    
    
    Co-authored-by: Peter Bengtsson <mail@peterbe.com>
  6. Merge #1531

    bors[bot] and renovate-bot committed Sep 17, 2018
    1531: Update dependency webpack to v4.19.0 r=mythmon a=renovate[bot]
    
    <p>This Pull Request updates devDependency <code>webpack</code> (<a href="https://renovatebot.com/gh/webpack/webpack">source</a>) from <code>v4.18.1</code> to <code>v4.19.0</code></p>
    <p>
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
  7. unit test untested checks

    peterbe committed Sep 17, 2018
    Part of #1223
  8. Merge #1537

    bors[bot] and renovate-bot committed Sep 17, 2018
    1537: Update dependency eslint to v5.6.0 r=mythmon a=renovate[bot]
    
    <p>This Pull Request updates devDependency <code>eslint</code> (<a href="https://eslint.org">homepage</a>, <a href="https://renovatebot.com/gh/eslint/eslint">source</a>) from <code>v5.5.0</code> to <code>v5.6.0</code></p>
    <p>
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
  9. Merge #1539

    bors[bot] and renovate-bot committed Sep 17, 2018
    1539: Update dependency babel-plugin-import to v1.9.1 r=mythmon a=renovate[bot]
    
    <p>This Pull Request updates devDependency <code>babel-plugin-import</code> (<a href="https://renovatebot.com/gh/ant-design/babel-plugin-import">source</a>) from <code>v1.8.0</code> to <code>v1.9.1</code></p>
    <p>
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
  10. Merge #1532

    bors[bot] and peterbe committed Sep 17, 2018
    1532: unset extra_filter_expression when you have a filter_object r=mythmon a=peterbe
    
    Fixes #1530
    
    Co-authored-by: Peter Bengtsson <mail@peterbe.com>
  11. Merge #1536

    bors[bot] and peterbe committed Sep 17, 2018
    1536: 1535 test coverage holes in api r=mythmon a=peterbe
    
    To test this I ran:
    
    ```bash
    pip install coverage
    coverage run -m pytest normandy && coverage html --skip-covered
    open htmlcov/index.html
    ```
    I also had to create a `.coveragerc` which I don't know if we can add to the repo since we don't do coverage testing regularly. But I had to create this:
    
    `.coveragerc`:
    ```
    [run]
    source = normandy
    branch = True
    data_file = /tmp/.coverage
    
    [report]
    omit =
        tests/*
        normandy/settings.py
        normandy/wsgi.py
        *management*
        *management/commands*
    
    [xml]
    output = /tmp/coverage.xml
    ```
    
    Co-authored-by: Peter Bengtsson <mail@peterbe.com>
Commits on Sep 16, 2018
  1. Update dependency babel-plugin-import to v1.9.1

    renovate-bot committed Sep 16, 2018
Commits on Sep 15, 2018
  1. Update dependency eslint to v5.6.0

    renovate-bot committed Sep 15, 2018
Commits on Sep 14, 2018
  1. adding .coveragerc and docs about how to use it

    peterbe committed Sep 14, 2018
  2. omitting extra_filter_expression with *empty* filter_object

    peterbe committed Sep 14, 2018
  3. unset extra_filter_expression when you have a filter_object

    peterbe committed Sep 14, 2018
    Fixes #1530
Commits on Sep 13, 2018
  1. Update dependency webpack to v4.19.0

    renovate-bot committed Sep 13, 2018
  2. Merge #1529

    bors[bot] and renovate-bot committed Sep 13, 2018
    1529: Update dependency webpack to v4.18.1 r=mythmon a=renovate[bot]
    
    <p>This Pull Request updates devDependency <code>webpack</code> (<a href="https://renovatebot.com/gh/webpack/webpack">source</a>) from <code>v4.18.0</code> to <code>v4.18.1</code></p>
    <p>
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
  3. Update dependency webpack to v4.18.1

    renovate-bot committed Sep 13, 2018
Commits on Sep 11, 2018
  1. Merge #1528

    bors[bot] and renovate-bot committed Sep 11, 2018
    1528: Update dependency @babel/core to v7.0.1 r=mythmon a=renovate[bot]
    
    <p>This Pull Request updates devDependency <code>@babel/core</code> (<a href="https://babeljs.io/">homepage</a>, <a href="https://renovatebot.com/gh/babel/babel">source</a>) from <code>v7.0.0</code> to <code>v7.0.1</code></p>
    <p>
    
    Co-authored-by: Renovate Bot <bot@renovateapp.com>
  2. Update dependency @babel/core to v7.0.1

    renovate-bot committed Sep 11, 2018