Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signing: Store bare signature from autograph, not content-signature #264

Merged
merged 2 commits into from Sep 20, 2016

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Sep 19, 2016

This changes the signatures stored in the database from x5u=URL;ecdsa384=SIG to just SIG. The rest of the data is already stored in the DB.

This will require changes to the system addon, since it was built against the longer version.

Copy link
Contributor

@Osmose Osmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, but the Autographer tests do not test the handling of the response coming back from Autograph, which is why this change doesn't cause test failures. We should be testing that.

@Osmose Osmose assigned mythmon and unassigned Osmose Sep 19, 2016
@Osmose Osmose merged commit 0448d19 into mozilla:master Sep 20, 2016
@mythmon mythmon deleted the just-the-sig branch September 20, 2016 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants