Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from update to revise #502

Merged
merged 1 commit into from Feb 13, 2017
Merged

Change from update to revise #502

merged 1 commit into from Feb 13, 2017

Conversation

rehandalal
Copy link
Contributor

r?

@mythmon
Copy link
Contributor

mythmon commented Feb 10, 2017

For context: @rehandalal and I discussed how update was confusing for a method that didn't directly change the object. For example, this test existed and was correct.

foo = RecipeFactory(name='first')
foo.update(name='second')
assert foo.name = 'first'

We decided revise was a better verb for this operation, since it creates new revisions.

Copy link
Contributor

@mythmon mythmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run this locally, because I'm confident in the tests to a refactor like this.

Copy link
Contributor

@chartjes chartjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the method rename, much clearer IMO

@mythmon mythmon merged commit eb9f71e into mozilla:peer-signing Feb 13, 2017
@rehandalal rehandalal deleted the update-to-revise branch April 17, 2017 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants