Support loading arbitrary npm dependencies in the add-on via webpack. #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 8, 2017 01:08
|
TC had a lint error but otherwise everything passed (I just pushed a fix for the lint issue). This should be ready for review! |
mythmon
approved these changes
Jul 11, 2017
gijsk
approved these changes
Jul 11, 2017
|
Github hates freedom and refuses to trigger our builds. We've already created at least one new PR in an attempt to get the builds triggering again, and the only thing that was broken in the last successful build was linting (which I just added an ignore comment for since the vendor built files aren't meant to be handled by humans). So I'm going to just merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See #871 for previous discussion.