Permalink
Commits on Apr 4, 2018
  1. Fix pseudo-classes for dark theme elements (#882)

    cedricium authored and vladikoff committed Apr 4, 2018
    Fixes #860
Commits on Mar 29, 2018
  1. Improvements to dark theme for multi-note support

    cedricium authored and vladikoff committed Mar 29, 2018
    Fixes #834 and fixes #844.
    
    - made title bar match the color of the '+ New Note' button
    - icon buttons given proper :hover, :active, and :focus states
    - made editor's editable area (background and color) match the rest of the dark theme
Commits on Mar 28, 2018
  1. Initial start at fixing dark theme for multi-notes (#821)

    cedricium authored and vladikoff committed Mar 28, 2018
Commits on Mar 21, 2018
  1. Blur context menu button when menu closes (#776) r=@vladikoff

    cedricium authored and vladikoff committed Mar 21, 2018
    Fixes #770
Commits on Mar 16, 2018
  1. Fix styling for footer button (dark theme) (#763) r=@vladikoff

    cedricium authored and vladikoff committed Mar 14, 2018
    Fixes #734. This adds the appropriate background colors when either hovering
    or when the button is focused or active. Also included was changing the syncing
    icon to be blue when hovered or in an active state, matching the default light
    theme.
  2. Use Notes content to name "Export as" filenames (#738)

    cedricium authored and vladikoff committed Mar 8, 2018
    Fixes #733
    Fixes #735
    
    Automatically name file 'blank.html' and change if child elements contain
    text. Also limit searching of child elements for text to a max of 20
    elements.
    
    Also introduced was a formatting function that:
      1. removes whitespace (`trim()`)
      2. removes illegal filename characters (`replace(regex)`)
      3. shortens filename if longer than 250 characters (`substring()`)
    
    Linting issues have also been resolved and should now pass CI tests.
    
    * Changes based on review
    
    Changes include:
    
     - making code more concise by using `filter()` and `find()` Array methods.
    
     - appending missing ".html" extension to filename
    
     - removing extra whitespace in code
  3. Fix Footer color issues for dark theme

    cedricium authored and vladikoff committed Feb 26, 2018
    Fixes #726
  4. Disable "Export" button while Notes syncs (#777)

    cedricium authored and vladikoff committed Mar 16, 2018
Commits on Mar 14, 2018
  1. Fix styling for footer button (dark theme) (#763) r=@vladikoff

    cedricium authored and vladikoff committed Mar 14, 2018
    Fixes #734. This adds the appropriate background colors when either hovering
    or when the button is focused or active. Also included was changing the syncing
    icon to be blue when hovered or in an active state, matching the default light
    theme.
Commits on Mar 8, 2018
  1. Use Notes content to name "Export as" filenames (#738)

    cedricium authored and vladikoff committed Mar 8, 2018
    Fixes #733
    Fixes #735
    
    Automatically name file 'blank.html' and change if child elements contain
    text. Also limit searching of child elements for text to a max of 20
    elements.
    
    Also introduced was a formatting function that:
      1. removes whitespace (`trim()`)
      2. removes illegal filename characters (`replace(regex)`)
      3. shortens filename if longer than 250 characters (`substring()`)
    
    Linting issues have also been resolved and should now pass CI tests.
    
    * Changes based on review
    
    Changes include:
    
     - making code more concise by using `filter()` and `find()` Array methods.
    
     - appending missing ".html" extension to filename
    
     - removing extra whitespace in code
Commits on Feb 28, 2018
  1. Fix browser-specific `start` scripts (#731) r=@vladikoff,@sebastienba…

    cedricium authored and vladikoff committed Feb 28, 2018
Commits on Feb 27, 2018
Commits on Feb 26, 2018
Commits on Feb 20, 2018
  1. Disable 'Send to Notes' context menu item in Notes

    cedricium committed Feb 20, 2018
    This disables the context menu item 'Send to Notes' from being created
    / rendered in Notes itself. The `<all_urls>` document url patter does
    not match `resource://...` paths, which is what Notes' index.html falls
    under.
Commits on Feb 16, 2018
  1. 'Send to Notes' context menu (#655)

    cedricium authored and vladikoff committed Feb 16, 2018
    Fixes #536
Commits on Jan 16, 2018
Commits on Jan 15, 2018
  1. Increased line height of list items

    cedricium committed Jan 15, 2018
    Fix for #569.
Commits on Dec 17, 2017
Commits on Nov 20, 2017
  1. Merge branch 'ckeditor-concept' of https://github.com/mozilla/notes i…

    cedricium committed Nov 20, 2017
    …nto ckeditor-concept
Commits on Nov 18, 2017
  1. Dark Theme touchups

    cedricium committed Nov 18, 2017
    Changes made result in the following:
    
     - fixed the heading dropdown border overlap issue
    
     - replicated `:hover` and `:active` styles from the light theme
    
     - added a border to tooltips to make them stand out better
Commits on Nov 14, 2017
  1. (Tried) Building Classic editor from source

    cedricium committed Nov 14, 2017
    This was an attempt to build the Classic editor from source as outlined
    in this guide: https://docs.ckeditor.com/ckeditor5/latest/builds/guide-
    s/integration/advanced-setup.html.
    
    This isn't bundled correctly however since ClassicEditor.js and
    Markdown.js are at the top-level of the directory and need to be inside
    the `sidebar/` directory.
Commits on Nov 7, 2017
  1. Added additional formats to be used by ckeditor

    cedricium committed Nov 7, 2017
    Formats added:
     - All text sizes
     - block quotes
    
    Also added the `cursor: text` to the text editor area.
Commits on Nov 2, 2017
  1. Enabled footer buttons functionality

    cedricium committed Nov 2, 2017
    The two footer buttons: `enable-sync` and `give-feedback` now work as
    intended. When `enable-sync` is clicked however, the `sync-note` covers
    the footer buttons currently instead of being displayed above them.
  2. Initial implementation of the ckeditor for Notes

    cedricium committed Nov 2, 2017
    This commit sets up the classic ckeditor to be used in place of quill.
    Most functionality (specifically with the footer buttons and syncing)
    do not work as of yet.
Commits on Oct 19, 2017
  1. Style MDL menu to match dark theme

    cedricium committed Oct 19, 2017
    Styled the material-design-lite (MDL) menu and it's items to match the
    style of the Notes dark theme.
  2. Give pasted text any active formatting

    cedricium committed Oct 19, 2017
    This is the second part that fixes #271. In the last PR, typing links
    with active formatting was applied, but when pasting links any for-
    matting would be dropped.
    
    This PR fixes this issue by getting the active formats at the focus
    of the editor then applies the formatting to the clipboard text
    before pasting it to the editor. This applies to both text and links as
    discussed in #322.
Commits on Oct 10, 2017
  1. Fix lint issues

    cedricium committed Oct 10, 2017
  2. Bug fixes for #179, #271, #273, and #286

    cedricium committed Oct 10, 2017
    This commit fixes several issues related to `links`.
    
     - #179 is fixed since the links are now underlined and highlighted blue
       like a hyperlink. Links are also clickable even when formatted with
       various formatting options (which was an issue before).
    
     - #271 was fixed in the last commit but made links not clickable - this
       nature has been fixed by traversing a clicked element's ancestors and
       opening the link if an `a` (anchor) tag is found.
    
     - #273 is fixed by taking care of the edge case when [Tab] is used before
       a link. This would cause a tab character to have the `link` format, this
       has been fixed by removing the `link` formatting for any whitespace characters
       before a link
    
     - #286 is fixed by specifically making sure the Delta objects for pasting a link
       in a bulleted or ordered list does not fall under the same category being matched
       as the fix for #273 (which was the cause of this)