From 7801d4cc419cc4b2ab4be80697aea8deed5eae80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20BARBIER?= Date: Tue, 20 Feb 2018 17:45:34 +0100 Subject: [PATCH 1/2] Disallow click event during syncing Simply add On click a check in current state if footer is clickable or not. Fix #708 --- src/sidebar/app/components/Footer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sidebar/app/components/Footer.js b/src/sidebar/app/components/Footer.js index ff1fd571c..653142bb2 100644 --- a/src/sidebar/app/components/Footer.js +++ b/src/sidebar/app/components/Footer.js @@ -188,7 +188,7 @@ class Footer extends React.Component { this.enableSyncAction = () => { // persist reconnect warning, do not override with the 'saved at' - if (this.state.state.ignoreChange) return; + if (this.state.state.ignoreChange || !this.state.state.isClickable) return; if (this.state.isAuthenticated) { // Trigger manual sync From b772642badc53c3469128d3aa12014c6fa248d48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20BARBIER?= Date: Tue, 20 Feb 2018 18:16:47 +0100 Subject: [PATCH 2/2] Using isClickable is enough, Thanks @Natim ;) --- src/sidebar/app/components/Footer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sidebar/app/components/Footer.js b/src/sidebar/app/components/Footer.js index 653142bb2..1c9014bf7 100644 --- a/src/sidebar/app/components/Footer.js +++ b/src/sidebar/app/components/Footer.js @@ -188,7 +188,7 @@ class Footer extends React.Component { this.enableSyncAction = () => { // persist reconnect warning, do not override with the 'saved at' - if (this.state.state.ignoreChange || !this.state.state.isClickable) return; + if (!this.state.state.isClickable) return; if (this.state.isAuthenticated) { // Trigger manual sync