Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change backpack Persona usage to the Observer API #511

Open
stenington opened this Issue Feb 11, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@stenington
Copy link
Contributor

commented Feb 11, 2013

Change over the badge acceptance flow to use the Persona Observer API. The returnTo for now should probably just be the index page, although this will pave the way for some fancy "Welcome to the Backpack" sort of thing.

@ghost ghost assigned stenington Feb 14, 2013

@stenington

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2013

I did a spike on this in stenington/openbadges@observer-stash, which @toolness has added his comments to. The spike needs to be reworked into a proper pull request at this point, but it seems like all the moving pieces are there. The spike code is live at http://stenington.org:8888 as well.

@stenington

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2013

Aaaaaand we have a problem: mozilla/persona#2999

@cmcavoy: @andrewhayward uncovered this while trying to take over this bug. With 3rd party cookies disabled, the Observer API repeatedly kicks you out of the app immediately after login.

@stenington

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2013

Looks like we might be able to detect this setting and warn users or suggest whitelisting persona: http://stackoverflow.com/questions/3550790/check-if-third-party-cookies-are-enabled/7104048#7104048

This was referenced Feb 22, 2013

toolness added a commit to toolness/openbadges that referenced this issue Feb 27, 2013

Added a basic /access view.
I don't like the inline JS in the page, but the existing logic in
static/js/badge-accept/badge-accept.js is pretty coupled to the
issuer frame, and we're going to be migrating to use the observer
API in mozilla#511 anyways, so the code will likely be pretty temporary.
@toolness

This comment has been minimized.

Copy link
Contributor

commented May 2, 2013

It looks like our blocking persona bug was fixed by mozilla/persona@013b48c.

That said, one of the new things we've added since filing this bug and making stenington/openbadges@observer-stash is the nifty test infrastructure in df88c31, which stubs out navigator.id.get(). We'll have to change that to stub out navigator.id.watch, request, and logout.

@satdav

This comment has been minimized.

Copy link

commented Apr 29, 2014

Can this please be added this week

@cmcavoy

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2014

Hi @satdav, I'm sorry but this won't be able to be added for a while, the core open badges team is working on another project right now. If you can submit a pull request, that would speed it up considerably! Thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.