Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[fixes #145] Don't show recipient on portfolio edit page. #146

Merged
merged 1 commit into from

2 participants

@brianloveswords

Fact: this should probably be fixed with a partial. That dumb <table> of information is used in three places and it's fully repeated in all three places.

@brianloveswords

@stenington Take a look at this and let me know if you think we should just do it the right way or keep kicking the can.

@stenington
Owner

A partial seems like a good idea. @brianloveswords Would you want to do that instead of this pull request, or should I go ahead and merge?

This change works as a quick-fix, but removing the recipient doesn't guarantee we won't see issue #145 again. A long unwrappable chunk of text in the criteria url, for example, will also have this problem.

#83 exists as a generic "make the badge details better" bug. I've added a comment to turn the table into a partial if it isn't one already. So it's up to you whether you want to pursue this now or someone can tackle it later, I guess.

@brianloveswords

I think we might as well merge this now and Do The Right Thing when we fix issue #83.

@stenington
Owner

Cool, agreed.

@stenington stenington merged commit 4c07f3e into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 8 deletions.
  1. +4 −8 views/portfolio-editor.hogan.js
View
12 views/portfolio-editor.hogan.js
@@ -38,7 +38,7 @@
</tr>
<tr>
<td class='fieldlabel issuer-name'>URL</td>
- <td><a href={{badge.issuer.origin}}'>{{badge.issuer.origin}}</a></td>
+ <td><a href="{{badge.issuer.origin}}">{{badge.issuer.origin}}</a></td>
</tr>
{{#badge.issuer.org}}
<tr>
@@ -63,17 +63,13 @@
<td><a href='{{badge.criteria}}'>{{badge.criteria}}</a></td>
</tr>
- <tr>
- <td class='section-head' colspan='2'>Issuance Details</td>
- </tr>
- <tr>
- <td class='fieldlabel recipient'>Recipient</td>
- <td>{{recipient}}</td>
- </tr>
+ {{#evidence}}
<tr>
<td class='fieldlabel evidence'>Evidence</td>
<td><a href='{{evidence}}'>{{evidence}}</a></td>
</tr>
+ {{/evidence}}
+
{{#issued_on}}
<tr>
<td class='fieldlabel'>Issued</td>
Something went wrong with that request. Please try again.