rename "Open Badge(s) Backpack" -> "Mozilla Backpack" #827

Merged
merged 3 commits into from Apr 11, 2013

Conversation

Projects
None yet
5 participants
Contributor

arasbm commented Apr 10, 2013

Contributor

threeqube commented Apr 11, 2013

Wow, @arasbm thanks so much for taking care of this!

Contributor

arasbm commented Apr 11, 2013

@threeqube no problem at all. I have lots of time over the next three weeks and want to learn and contribute. Feel free to assign some frontend issues that noone else is working on, to me

Contributor

threeqube commented Apr 11, 2013

@stenington and I will discuss what are some of the things we can assign to you. Thanks again so much!

views/login.html
@@ -1,7 +1,7 @@
{% extends 'layout.html' %}
{% set bodyClass = 'login' %}
{% block body %}
-<h1 class="title">Welcome to your Backpack</h1>
+<h1 class="title">Welcome to your Mozilla Backpack</h1>
@stenington

stenington Apr 11, 2013

Contributor

@iamjessklein @threeqube Should the "Welcome to your Backpack" message on the login page also change to say "Mozilla Backpack", or does that reference remain unchanged?

@iamjessklein

iamjessklein Apr 11, 2013

Contributor

Good question. @threeqube ?

On Thu, Apr 11, 2013 at 12:24 PM, Mike Larsson notifications@github.comwrote:

In views/login.html:

@@ -1,7 +1,7 @@
{% extends 'layout.html' %}
{% set bodyClass = 'login' %}
{% block body %}
-

Welcome to your Backpack


+

Welcome to your Mozilla Backpack

@iamjessklein https://github.com/iamjessklein @threequbehttps://github.com/threequbeShould the "Welcome to your Backpack" message on the login page also change
to say "Mozilla Backpack", or does that reference remain unchanged?


Reply to this email directly or view it on GitHubhttps://github.com/mozilla/openbadges/pull/827/files#r3756517
.

@threeqube

threeqube Apr 11, 2013

Contributor

@emgollie ? I think it's fine for it just to say "Welcome to your Backpack" but want @emgollie to have final say.

@emgollie

emgollie Apr 11, 2013

"Welcome to your Backpack" works well.

@arasbm

arasbm Apr 11, 2013

Contributor

I added a commit to set the title back to "Welcome to your Backpack" just for the login page. Hope that works, thanks.

Contributor

stenington commented Apr 11, 2013

Cool, looks good!

stenington added a commit that referenced this pull request Apr 11, 2013

Merge pull request #827 from arasbm/development
rename "Open Badge(s) Backpack" -> "Mozilla Backpack"

@stenington stenington merged commit 7c761e9 into mozilla:development Apr 11, 2013

1 check passed

default The Travis build passed
Details

bkeyvani added a commit to bkeyvani/openbadges that referenced this pull request Apr 15, 2013

set login page title back to "Welcome to your Backpack"
 * modifying pull request #827 which is for issue #790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment