Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Link to bug for 127.0.0.1 workaround

  • Loading branch information...
commit a5b42315c6cefe4d9209be69b35a0a9ee2422926 1 parent e6249ab
@anantn anantn authored
Showing with 5 additions and 4 deletions.
  1. +4 −2 addons/jetpack/lib/api.js
  2. +1 −2  addons/jetpack/lib/main.js
View
6 addons/jetpack/lib/api.js
@@ -176,7 +176,9 @@ FFRepoImpl.prototype = {
getSelf: function(origin) {
let pendingGetSelf = new pendingOperation("getSelf");
Repo.getSelf(origin, function(app) {
- // FIXME: what's the error case?
+ // Errors are either thrown by getSelf, or notified
+ // via an empty argument to the success handler,
+ // hence we never call pendingGetSelf.onerror
if (pendingGetSelf.onsuccess) {
let appObj = null;
if (app) {
@@ -263,7 +265,7 @@ FFRepoImpl.prototype = {
}, 5000, Ci.nsITimer.TYPE_ONE_SHOT);
},
-
+
install: function _install(location, args, window) {
let self = this;
View
3  addons/jetpack/lib/main.js
@@ -233,8 +233,7 @@ MozAppsAPI.prototype = {
};
// If install is triggered from 127.0.0.1, don't show doorhanger
- // FIXME: how can we implement this without giving all of 127.0.0.1
- // the privilege to bypass the doorhanger?
+ // See https://bugzilla.mozilla.org/show_bug.cgi?id=727255 for implications
let domain = "http://127.0.0.1";
let origin = aWindow.location.toString();
if (origin.substr(0, domain.length) == domain) {
Please sign in to comment.
Something went wrong with that request. Please try again.