From 812cfe76a49baad021144b3591a0a043c6a53f76 Mon Sep 17 00:00:00 2001 From: Peter deHaan Date: Wed, 10 Aug 2016 16:06:07 -0700 Subject: [PATCH 1/2] Add support for Open Graph og:image:secure_url --- parser.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/parser.js b/parser.js index f7232ab..a628155 100644 --- a/parser.js +++ b/parser.js @@ -49,6 +49,8 @@ const iconRules = buildRuleset('icon', [ ]); const imageRules = buildRuleset('image', [ + ['meta[property="og:image:secure_url"]', node => node.element.content], + ['meta[property="og:image:url"]', node => node.element.content], ['meta[property="og:image"]', node => node.element.content], ['meta[property="twitter:image"]', node => node.element.content], ['meta[name="thumbnail"]', node => node.element.content], From 968e94461de431deafa6f8f20eb061820f0ca139 Mon Sep 17 00:00:00 2001 From: Peter deHaan Date: Wed, 10 Aug 2016 16:22:47 -0700 Subject: [PATCH 2/2] Add tests for og:image:url and og:image:secure_url --- tests/getMetadata.test.js | 11 +++++++---- tests/metadataRules.test.js | 2 ++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tests/getMetadata.test.js b/tests/getMetadata.test.js index b22d9f0..dea360e 100644 --- a/tests/getMetadata.test.js +++ b/tests/getMetadata.test.js @@ -6,7 +6,8 @@ const {stringToDom} = require('./test-utils'); describe('Get Metadata Tests', function() { const sampleDescription = 'A test page.'; const sampleIcon = 'http://www.example.com/favicon.ico'; - const sampleImage = 'http://www.example.com/image.png'; + const sampleImageHTTP = 'http://www.example.com/image.png'; + const sampleImageHTTPS = 'https://www.example.com/secure_image.png'; const sampleTitle = 'Page Title'; const sampleType = 'article'; const sampleUrl = 'http://www.example.com/'; @@ -16,7 +17,9 @@ describe('Get Metadata Tests', function() { - + + + @@ -30,7 +33,7 @@ describe('Get Metadata Tests', function() { assert.equal(metadata.description, sampleDescription, `Unable to find ${sampleDescription} in ${sampleHtml}`); assert.equal(metadata.icon_url, sampleIcon, `Unable to find ${sampleIcon} in ${sampleHtml}`); - assert.equal(metadata.image_url, sampleImage, `Unable to find ${sampleImage} in ${sampleHtml}`); + assert.equal(metadata.image_url, sampleImageHTTPS, `Unable to find ${sampleImageHTTPS} in ${sampleHtml}`); assert.equal(metadata.title, sampleTitle, `Unable to find ${sampleTitle} in ${sampleHtml}`); assert.equal(metadata.type, sampleType, `Unable to find ${sampleType} in ${sampleHtml}`); assert.equal(metadata.url, sampleUrl, `Unable to find ${sampleUrl} in ${sampleHtml}`); @@ -74,7 +77,7 @@ describe('Get Metadata Tests', function() { assert.equal(metadata.openGraph.url, sampleUrl, 'Error finding url'); assert.equal(metadata.media.icon, sampleIcon, 'Error finding icon'); - assert.equal(metadata.media.image, sampleImage, 'Error finding image'); + assert.equal(metadata.media.image, sampleImageHTTPS, 'Error finding image'); }); }); diff --git a/tests/metadataRules.test.js b/tests/metadataRules.test.js index 2ddc647..17581e5 100644 --- a/tests/metadataRules.test.js +++ b/tests/metadataRules.test.js @@ -71,6 +71,8 @@ describe('Image Rule Tests', function() { const ruleTests = [ ['og:image', ``], + ['og:image:url', ` `], + ['og:image:secure_url', ` `], ['twitter:image', ``], ['thumbnail', ``], ['img', ``],