From c78a41a41ab3c624dcd59365705c747a25ae4ab1 Mon Sep 17 00:00:00 2001 From: Peter deHaan Date: Thu, 15 Sep 2016 15:23:05 -0700 Subject: [PATCH] Fix Twitter uses 'name' not 'property' attribute --- parser.js | 2 ++ tests/metadataRules.test.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/parser.js b/parser.js index 2707be1..131a6e1 100644 --- a/parser.js +++ b/parser.js @@ -73,6 +73,7 @@ const metadataRules = { ['meta[property="og:image:secure_url"]', node => node.element.getAttribute('content')], ['meta[property="og:image:url"]', node => node.element.getAttribute('content')], ['meta[property="og:image"]', node => node.element.getAttribute('content')], + ['meta[name="twitter:image"]', node => node.element.getAttribute('content')], ['meta[property="twitter:image"]', node => node.element.getAttribute('content')], ['meta[name="thumbnail"]', node => node.element.getAttribute('content')], ], @@ -93,6 +94,7 @@ const metadataRules = { title: { rules: [ ['meta[property="og:title"]', node => node.element.getAttribute('content')], + ['meta[name="twitter:title"]', node => node.element.getAttribute('content')], ['meta[property="twitter:title"]', node => node.element.getAttribute('content')], ['meta[name="hdl"]', node => node.element.getAttribute('content')], ['title', node => node.element.text], diff --git a/tests/metadataRules.test.js b/tests/metadataRules.test.js index 6790b05..eb86078 100644 --- a/tests/metadataRules.test.js +++ b/tests/metadataRules.test.js @@ -31,6 +31,7 @@ describe('Title Rule Tests', function() { const ruleTests = [ ['og:title', ``], + ['twitter:title', ``], ['twitter:title', ``], ['hdl', ``], ['title', `${pageTitle}`], @@ -81,6 +82,7 @@ describe('Image Rule Tests', function() { ['og:image', ``], ['og:image:url', ` `], ['og:image:secure_url', ` `], + ['twitter:image', ``], ['twitter:image', ``], ['thumbnail', ``], ['relative image', ``],