Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix loading sequence issues affecting localisation

  • Loading branch information...
commit 6f3f952b8a52d61980be9f0cfff8ff4f03537dfe 1 parent 034de52
@birtles birtles authored
View
2  editor/public/index.html.php
@@ -19,7 +19,7 @@
<link rel="resource" type="application/l10n" href="locales.ini">
<script type="text/javascript" src="js/l10n.js"></script>
<script type="text/javascript" src="js/parapara.core.js" defer></script>
- <script type="text/javascript" src="js/editor-ui.js" defer></script>
+ <script type="text/javascript" src="js/editor-ui.js"></script>
<script type="text/javascript" src="js/qrcode.js" async></script>
<meta name="viewport"
content="width=device-width, initial-scale=1.0, user-scalable=no">
View
6 editor/public/js/editor-ui.js.php
@@ -119,9 +119,9 @@
// Set the preferred language on the document
//
// We need to do this before webL10n does its start-up sequence which is
-// triggered by the DOMContentLoaded event. So long as this script is not
-// included async (defer is ok) the following should run before
-// DOMContentLoaded.
+// triggered by the DOMContentLoaded event. That means that *this* script should
+// not be included as async or defer to ensure the following runs before
+// DOMContentLoaded is fired on webL10n.
//
// (The alternative, detecting if webL10n has started or not, and whether it has
// started but is still waiting for resources to load, far more complex.)
Please sign in to comment.
Something went wrong with that request. Please try again.