Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligature glyphs (fi, ff, fl) missing #1232

Closed
fwenzel opened this issue Feb 16, 2012 · 16 comments
Closed

Ligature glyphs (fi, ff, fl) missing #1232

fwenzel opened this issue Feb 16, 2012 · 16 comments

Comments

@fwenzel
Copy link
Member

@fwenzel fwenzel commented Feb 16, 2012

In the following document, certain combinations of two letters are given separate glyphs as a matter of good typesetting (for example: fi, ff, fl). pdf.js just renders gaps instead of glyphs there. It also seems an en-dash was not rendered either.

Document: http://rsw.beck.de/rsw/upload/NVwZ/NVwZ-Extra_2012_03.pdf
pdf.js rendering issues, screenshot: https://skitch.com/fredw/8nj5r/glyphs-missing
the same spots rendered correctly in OSX's preview.app: https://skitch.com/fredw/8njh4/glyphs-osx-preview

@fmms
Copy link

@fmms fmms commented Feb 16, 2012

I can confirm the ligatures to be a problem.

Although for me they give random characters (i.e. ff is €) instead of white space.

Linux. Firefox 10. pdf.js 0.2.274

@fwenzel
Copy link
Member Author

@fwenzel fwenzel commented Feb 16, 2012

Ah yes, a ligature, not diphthong. Thanks :)

@notmasteryet
Copy link
Contributor

@notmasteryet notmasteryet commented Feb 17, 2012

OTS log:

ERROR at ../src/cff.cc:764 (bool <anonymous namespace>::ParseDictData(const uint8_t *, size_t, const ots::CFFIndex &, size_t, <anonymous>::DICT_DATA_TYPE, ots::OpenTypeCFF *))

ERROR at ../src/cff.cc:950 (bool ots::ots_cff_parse(ots::OpenTypeFile *, const uint8_t *, size_t))

ERROR at ../src/ots.cc:442 (bool <anonymous namespace>::ProcessGeneric(ots::OpenTypeFile *, ots::OTSStream *, const uint8_t *, size_t, const std::vector<OpenTypeTable> &, ots::Buffer &))

Failed to sanitise file!

Duplicate of #1158

@msridhar
Copy link

@msridhar msridhar commented Feb 20, 2012

In case it's helpful, here's another document that shows the ligature issue:

http://hse-econ.fi/tervio/MediocritiesAndSuperstars.pdf

See, e.g., "self nance" rather than "self finance" in the abstract.

I observed the issue using FF 13.0a1 (2012-02-20) and pdf.js 0.2.285.

@notmasteryet
Copy link
Contributor

@notmasteryet notmasteryet commented Feb 20, 2012

The pdf files might have different font problems even it looks/sounds similar.

@msridhar please file separate issue for your pdf file.

@notmasteryet
Copy link
Contributor

@notmasteryet notmasteryet commented Feb 20, 2012

@msridhar thank you for opening a new issue

@brendandahl
Copy link
Contributor

@brendandahl brendandahl commented Mar 23, 2012

The issue should be resolved with the above pull request. If I overlooked anything please leave a comment and we'll re-open the issue.

@fwenzel
Copy link
Member Author

@fwenzel fwenzel commented Mar 23, 2012

I just checked the document above and seems like it's working fine. Thanks Brendan!

@enozkan
Copy link

@enozkan enozkan commented Mar 29, 2012

I thought this was fixed too, but now, using the latest development version (0.2.476) in Firefox 11.0 (Mac), the above-mentioned PDF (in German) and many others do not display the fi ligatures. They are replaced by spaces.

Can anyone else confirm this?

@brendandahl
Copy link
Contributor

@brendandahl brendandahl commented Mar 29, 2012

Still seems fine to me @arturadib could you try out the above pdf and see if ligatures are missing?

@fmms
Copy link

@fmms fmms commented Mar 29, 2012

fine here with FF11 and 0.2.476 on Ubuntu 11.10.

@arturadib
Copy link
Contributor

@arturadib arturadib commented Mar 30, 2012

The ligatures are fine here too (OS X, PDF.js addon 0.2.476).

@enozkan
Copy link

@enozkan enozkan commented Mar 31, 2012

Yep, they are fine also on my other OS X 10.7 machine, but for some reason not on this 10.6.8 with latest updates. Also with a fresh profile and no other add-ons.

Edit: Confirmed it on two more 10.6 machines. But 10.7 appears to be fine.

@ri0t
Copy link

@ri0t ri0t commented Jul 30, 2015

Funny sh*t, i now have this all over firefox :)
Doesn't look too nice.. apparently someone decided to replicate this featurebug in the main application - cool.

@rajasuba
Copy link

@rajasuba rajasuba commented May 23, 2016

I'm facing the similar issue with the latest version (14.06) of pdf2htmlEX tool

Kindly look into this

coolwanglu/pdf2htmlEX#634

@brendandahl
Copy link
Contributor

@brendandahl brendandahl commented May 24, 2016

@rajasuba Please file a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants