Move/refactor the code in the BaseViewer.update method to reduce duplication in the extending classes
#10466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-windows lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1e42a1d4774585a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6ae882453c2d169/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/1e42a1d4774585a/output.txt Total script time: 1.65 mins Published |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6ae882453c2d169/output.txt Total script time: 2.39 mins
|
…plication in the extending classes Since most of the important rendering code is already (almost) identical between `PDFViewer.update` and `PDFSinglePageViewer.update`, it's possible to further reduce duplication by moving the code into `BaseViewer.update` instead.
Snuffleupagus
force-pushed
the
BaseViewer-update
branch
from
911ea7f
to
343f488
Compare
timvandermeij
approved these changes
Jan 18, 2019
|
Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most of the important rendering code is already (almost) identical between
PDFViewer.updateandPDFSinglePageViewer.update, it's possible to further reduce duplication by moving the code intoBaseViewer.updateinstead.