Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the canvas npm package to fix Travis CI builds (issue 10790) #10795

Merged
merged 2 commits into from May 8, 2019

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented May 8, 2019

Fixes #10790

@Snuffleupagus
Copy link
Collaborator Author

This seems to have worked, however there's now a new failure related to rounding:

Failures:
1) parser Lexer getNumber should parse PostScript numbers
  Message:
    Expected 0.000009999999999999999 to equal 0.00001.
  Stack:
    Error: Expected 0.000009999999999999999 to equal 0.00001.
        at <Jasmine>
        at UserContext.<anonymous> (/home/travis/build/mozilla/pdf.js/build/lib/test/unit/parser_spec.js:96:37)
        at <Jasmine>

Apparently Chromium is no longer able to correctly evaluate Math.pow(10, -5), or other negative exponents, without introducing rounding errors :-(
In my opinion, adding hacks to the core code to work-around this isn't really acceptable given the possible performance overhead. If we care about trying to "fix" this, allowing fuzzy matching in the should parse PostScript numbers unit-tests seems like a better option to me.

…rk-around rounding bugs in Chromium browsers
@brendandahl
Copy link
Contributor

@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented May 8, 2019

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/f8762ba6fc3b25e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 8, 2019

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c0f65c1c068cbf0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 8, 2019

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/c0f65c1c068cbf0/output.txt

Total script time: 2.69 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 8, 2019

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/f8762ba6fc3b25e/output.txt

Total script time: 5.62 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit ca2fee3 into mozilla:master May 8, 2019
@timvandermeij
Copy link
Contributor

Looks good!

@Snuffleupagus Snuffleupagus deleted the issue-10790 branch May 9, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Travis CI builds
4 participants