Inline the isString check in the Parser.getObj method
#11070
Conversation
Snuffleupagus
force-pushed
the
Parser-getObj-rm-isString
branch
from
527c706
to
4a4aa26
Compare
For very large and complex PDF files this will help performance *slightly*, since `Parser.getObj` is called *a lot* during parsing in the worker. This patch was tested using the PDF file from issue 2618, i.e. http://bugzilla-attachments.gnome.org/attachment.cgi?id=226471, with the following manifest file: ``` [ { "id": "issue2618", "file": "../web/pdfs/issue2618.pdf", "md5": "", "rounds": 200, "type": "eq" } ] ``` which gave the following results when comparing this patch against the `master` branch: ``` -- Grouped By browser, stat -- browser | stat | Count | Baseline(ms) | Current(ms) | +/- | % | Result(P<.05) ------- | ------------ | ----- | ------------ | ----------- | --- | ----- | ------------- Firefox | Overall | 200 | 2847 | 2830 | -17 | -0.60 | faster Firefox | Page Request | 200 | 2 | 2 | 0 | -7.14 | Firefox | Rendering | 200 | 2844 | 2827 | -17 | -0.60 | faster ```
Snuffleupagus
force-pushed
the
Parser-getObj-rm-isString
branch
from
4a4aa26
to
7728a66
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0e8274554a029dc/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f0f2f0f48f0ce8a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/0e8274554a029dc/output.txt Total script time: 17.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f0f2f0f48f0ce8a/output.txt Total script time: 25.98 mins
|
Snuffleupagus
force-pushed
the
Parser-getObj-rm-isString
branch
from
5a3f1a9
to
99df151
Compare
This avoids allocating approximately 1.7 million short-lived variables when loading the PDF file from issue 2618, i.e. http://bugzilla-attachments.gnome.org/attachment.cgi?id=226471, in the default viewer.
Snuffleupagus
force-pushed
the
Parser-getObj-rm-isString
branch
from
99df151
to
40d3916
Compare
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6bd962a1c36fcf7/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/49c9192de34ae57/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/49c9192de34ae57/output.txt Total script time: 17.46 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6bd962a1c36fcf7/output.txt Total script time: 26.15 mins
|
|
Looks good! |
For very large and complex PDF files this will help performance slightly, since
Parser.getObjis called a lot during parsing in the worker.This patch was tested using the PDF file from issue #2618, i.e. http://bugzilla-attachments.gnome.org/attachment.cgi?id=226471, with the following manifest file:
which gave the following results when comparing this patch against the
masterbranch: