Allow skipping of errors when parsing broken/unsupported ColorSpaces (issue 6707, issue 11287) #11296
Conversation
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/b936f148ad3298b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c31f94eab7ff74b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c31f94eab7ff74b/output.txt Total script time: 18.55 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/b936f148ad3298b/output.txt Total script time: 26.55 mins
Image differences available at: http://54.215.176.217:8877/b936f148ad3298b/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
parseColorSpace-stopAtErrors
branch
from
2b6ecdf
to
789d908
Compare
| colorSpace = await this.parseColorSpace({ | ||
| cs: group.get('CS'), | ||
| resources, | ||
| }); |
There was a problem hiding this comment.
This is essentially a better, and more general, version of PR 11047; as suggested in #11047 (comment)
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d13222598bc00da/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/d85d251f6e5ae0b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d13222598bc00da/output.txt Total script time: 18.61 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/d85d251f6e5ae0b/output.txt Total script time: 26.56 mins
Image differences available at: http://54.215.176.217:8877/d85d251f6e5ae0b/reftest-analyzer.html#web=eq.log |
…(issue 6707, issue 11287) This will allow us to attempt to recover as much as possible of a page, rather than immediately failing, when a broken/unsupported ColorSpace is encountered. This patch thus extends the framework added in PRs such as e.g. 8240 and 8922, to also cover parsing of ColorSpaces.
Snuffleupagus
force-pushed
the
parseColorSpace-stopAtErrors
branch
from
789d908
to
835d8c2
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bb43b9ae271a0c9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a12bceb15d8c3d3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/bb43b9ae271a0c9/output.txt Total script time: 18.61 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/a12bceb15d8c3d3/output.txt Total script time: 26.62 mins
Image differences available at: http://54.215.176.217:8877/a12bceb15d8c3d3/reftest-analyzer.html#web=eq.log |
|
This seems like a good approach; thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8c3a25385865b42/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/a9f04f7eba0007a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8c3a25385865b42/output.txt Total script time: 16.87 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/a9f04f7eba0007a/output.txt Total script time: 23.89 mins
|
This will allow us to attempt to recover as much as possible of a page, rather than immediately failing, when a broken/unsupported ColorSpace is encountered. This patch thus extends the framework added in PRs such as e.g. #8240 and #8922, to also cover parsing of ColorSpaces.
Fixes #6707
Fixes #11287