Skip to content
This repository

Fix gradients for fill and stroke. #1443

Merged
merged 3 commits into from about 2 years ago

4 participants

Brendan Dahl pdf.js test bot Artur Adib Yury Delendik
Brendan Dahl
Collaborator

The radial and axial gradients were never setting the fillStyle of the context, hence why in the pdf below the whole page was just filled with black.

I also removed some unused ctx variables that were being passed around. That code is all worker code and would never have the ctx anyway.

Last, the gradients and pattern code needs lots of work. There are a lot of things we are ignoring right now such as bounding boxes, extend, and I think we may not be handling all the transformations correctly (especially in the case of form xobjects with patterns).

Expected to break:
issue1001.pdf

Fixes:
https://bugzilla.mozilla.org/show_bug.cgi?id=738979

Brendan Dahl
Collaborator

@pdfjsbot test

pdf.js test bot
Collaborator

Processing command test by user brendandahl. Queue size: 0

Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4824677.txt

[bot:processed:4824677]

pdf.js test bot
Collaborator

ERROR(s) found

ATTENTION: There was a snapshot difference:
http://184.73.87.52:8989/tests/7008d07fde21ab4b630708805796dc6e807b5b9a/reftest-analyzer.xhtml#web=/tests/7008d07fde21ab4b630708805796dc6e807b5b9a/eq.log

Output:

========== Killing any stray processes

========== Running garbage collector in /mnt/pdfjsbot-tmp
Collecting garbage...

========== Cloning pull request repo
Cloning into ....

========== Merging upstream into pull request clone

========== Running 'make lint'
gjslint --nojsdoc  src/bidi.js src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metadata.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js    web/compatibility.js web/debugger.js web/viewer.js  test/driver.js  examples/helloworld/hello.js  extensions/firefox/bootstrap.js  extensions/firefox/components/PdfStreamConverter.js    test/unit/crypto_spec.js test/unit/font_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js
35 files checked, no errors found.

========== Cloning reference images repo into test/ref/
Initialized empty Git repository in /mnt/pdfjsbot-tmp/tests/7008d07fde21ab4b630708805796dc6e807b5b9a/test/ref/.git/

========== Checking for consistency with reference repo

========== Running 'make bot_test'
Xvfb: no process found
cd test; \
    python -u test.py \
    --browserManifestFile=resources/browser_manifests/browser_manifest.json \
    --manifestFile=test_manifest.json
Launching firefox
Launching chrome
TEST-PASS | eq test tracemonkey-eq | in chrome
TEST-PASS | eq test tracemonkey-eq | in firefox
TEST-PASS | forward-back-forward test tracemonkey-fbf | in chrome
TEST-PASS | load test html5-canvas-cheat-sheet-load | in chrome
TEST-PASS | forward-back-forward test tracemonkey-fbf | in firefox
TEST-PASS | load test html5-canvas-cheat-sheet-load | in firefox
TEST-PASS | eq test intelisa-eq | in chrome
TEST-PASS | eq test intelisa-eq | in firefox
TEST-PASS | load test pdfspec-load | in chrome
TEST-PASS | load test shavian-load | in chrome
TEST-UNEXPECTED-FAIL | eq sizes | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test plusminus | in chrome
TEST-PASS | load test openoffice-pdf | in chrome
TEST-PASS | load test openofficecidtruetype-pdf | in chrome
TEST-PASS | load test openofficearabiccidtruetype-pdf | in chrome
TEST-PASS | load test arabiccidtruetype-pdf | in chrome
TEST-PASS | load test complexttffont-pdf | in chrome
TEST-PASS | eq test thuluthfont-pdf | in chrome
TEST-PASS | eq test freeculture | in chrome
TEST-PASS | eq test wnv_chinese-pdf | in chrome
TEST-PASS | eq test i9-pdf | in chrome
TEST-PASS | load test hmm-pdf | in chrome
TEST-PASS | eq test rotation | in chrome
TEST-PASS | load test ecma262-pdf | in chrome
TEST-PASS | load test jai-pdf | in chrome
TEST-PASS | eq test cable | in chrome
TEST-PASS | eq test pdkids | in chrome
TEST-PASS | eq test artofwar | in chrome
TEST-PASS | eq test wdsg_fitc | in chrome
TEST-PASS | eq test unix01 | in chrome
TEST-PASS | load test pdfspec-load | in firefox
TEST-PASS | load test shavian-load | in firefox
TEST-PASS | eq test sizes | in firefox
TEST-PASS | eq test plusminus | in firefox
TEST-PASS | load test openoffice-pdf | in firefox
TEST-PASS | load test openofficecidtruetype-pdf | in firefox
TEST-PASS | load test openofficearabiccidtruetype-pdf | in firefox
TEST-PASS | load test arabiccidtruetype-pdf | in firefox
TEST-PASS | load test complexttffont-pdf | in firefox
TEST-PASS | eq test thuluthfont-pdf | in firefox
TEST-PASS | eq test freeculture | in firefox
TEST-PASS | eq test wnv_chinese-pdf | in firefox
TEST-PASS | eq test fit11-talk | in chrome
TEST-PASS | eq test i9-pdf | in firefox
TEST-PASS | eq test fips197 | in chrome
TEST-PASS | load test txt2pdf | in chrome
TEST-PASS | load test f1040 | in chrome
TEST-PASS | load test hmm-pdf | in firefox
TEST-PASS | eq test rotation | in firefox
TEST-PASS | load test hudsonsurvey | in chrome
TEST-PASS | eq test extgstate | in chrome
TEST-PASS | eq test usmanm-bad | in chrome
TEST-PASS | load test vesta-bad | in chrome
TEST-PASS | load test scan-bad | in chrome
TEST-PASS | load test ibwa-bad | in chrome
TEST-PASS | eq test tcpdf_033 | in chrome
TEST-PASS | eq test pal-o47 | in chrome
TEST-PASS | eq test simpletype3font | in chrome
TEST-PASS | eq test close-path-bug | in chrome
TEST-PASS | eq test alphatrans | in chrome
TEST-PASS | eq test devicen | in chrome
TEST-PASS | eq test cmykjpeg | in chrome
TEST-PASS | eq test protectip | in chrome
TEST-PASS | eq test piperine | in chrome
TEST-PASS | eq test issue840 | in chrome
TEST-PASS | eq test bpl13210 | in chrome
TEST-PASS | eq test tutorial | in chrome
TEST-PASS | eq test geothermal.pdf | in chrome
TEST-PASS | eq test lista_preliminar | in chrome
TEST-PASS | eq test issue919 | in chrome
TEST-PASS | eq test issue918 | in chrome
TEST-UNEXPECTED-FAIL | eq issue1001 | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test aboutstacks | in chrome
TEST-PASS | eq test smaskdim | in chrome
TEST-PASS | eq test type4psfunc | in chrome
TEST-PASS | load test ocs | in chrome
TEST-PASS | eq test issue1010 | in chrome
TEST-PASS | eq test issue1015 | in chrome
TEST-PASS | load test ecma262-pdf | in firefox
TEST-PASS | eq test issue1096 | in chrome
TEST-PASS | eq test issue1127 | in chrome
TEST-PASS | load test issue1249-load | in chrome
TEST-PASS | load test liveprogramming | in chrome
TEST-PASS | eq test S2-eq | in chrome
TEST-PASS | eq test issue1055 | in chrome
TEST-PASS | eq test issue1169 | in chrome
TEST-PASS | eq test zerowidthline | in chrome
TEST-PASS | eq test html5checker | in chrome
TEST-PASS | eq test pdfkit_compressed | in chrome
TEST-PASS | eq test tamreview | in chrome
TEST-PASS | eq test preistabelle | in chrome
TEST-PASS | eq test issue1350 | in chrome
TEST-PASS | eq test issue925 | in chrome
TEST-PASS | eq test issue1133 | in chrome
TEST-PASS | eq test issue1049 | in chrome
TEST-PASS | eq test issue1155 | in chrome
TEST-PASS | eq test issue1002 | in chrome
TEST-PASS | eq test issue1243 | in chrome
TEST-PASS | eq test issue1257 | in chrome
TEST-PASS | eq test issue1309 | in chrome
TEST-PASS | eq test issue1317 | in chrome
WARNING: no reference snapshot ref/linux2/chrome/gradientfill/1
TEST-PASS | eq test gradientfill | in chrome
TEST-PASS | load test jai-pdf | in firefox
TEST-PASS | eq test cable | in firefox
TEST-PASS | eq test pdkids | in firefox
TEST-PASS | eq test artofwar | in firefox
TEST-PASS | eq test wdsg_fitc | in firefox
TEST-PASS | eq test unix01 | in firefox
TEST-PASS | eq test fit11-talk | in firefox
TEST-PASS | eq test fips197 | in firefox
TEST-PASS | load test txt2pdf | in firefox
TEST-PASS | load test f1040 | in firefox
TEST-PASS | load test hudsonsurvey | in firefox
TEST-PASS | eq test extgstate | in firefox
TEST-PASS | eq test usmanm-bad | in firefox
TEST-PASS | load test vesta-bad | in firefox
TEST-PASS | load test scan-bad | in firefox
TEST-PASS | load test ibwa-bad | in firefox
TEST-PASS | eq test tcpdf_033 | in firefox
TEST-PASS | eq test pal-o47 | in firefox
TEST-PASS | eq test simpletype3font | in firefox
TEST-PASS | eq test close-path-bug | in firefox
TEST-PASS | eq test alphatrans | in firefox
TEST-PASS | eq test devicen | in firefox
TEST-PASS | eq test cmykjpeg | in firefox
TEST-PASS | eq test protectip | in firefox
TEST-PASS | eq test piperine | in firefox
TEST-UNEXPECTED-FAIL | eq issue840 | in firefox | rendering of page 1 != reference rendering
TEST-PASS | eq test bpl13210 | in firefox
TEST-PASS | eq test tutorial | in firefox
TEST-PASS | eq test geothermal.pdf | in firefox
TEST-PASS | eq test lista_preliminar | in firefox
TEST-PASS | eq test issue919 | in firefox
TEST-PASS | eq test issue918 | in firefox
TEST-UNEXPECTED-FAIL | eq issue1001 | in firefox | rendering of page 1 != reference rendering
TEST-PASS | eq test aboutstacks | in firefox
TEST-PASS | eq test smaskdim | in firefox
TEST-PASS | eq test type4psfunc | in firefox
TEST-PASS | load test ocs | in firefox
TEST-PASS | eq test issue1010 | in firefox
TEST-PASS | eq test issue1015 | in firefox
TEST-PASS | eq test issue1096 | in firefox
TEST-PASS | eq test issue1127 | in firefox
TEST-PASS | load test issue1249-load | in firefox
TEST-PASS | load test liveprogramming | in firefox
TEST-PASS | eq test S2-eq | in firefox
TEST-PASS | eq test issue1055 | in firefox
TEST-PASS | eq test issue1169 | in firefox
TEST-PASS | eq test zerowidthline | in firefox
TEST-PASS | eq test html5checker | in firefox
TEST-PASS | eq test pdfkit_compressed | in firefox
TEST-PASS | eq test tamreview | in firefox
TEST-PASS | eq test preistabelle | in firefox
TEST-PASS | eq test issue1350 | in firefox
TEST-PASS | eq test issue925 | in firefox
TEST-PASS | eq test issue1133 | in firefox
TEST-PASS | eq test issue1049 | in firefox
TEST-PASS | eq test issue1155 | in firefox
TEST-PASS | eq test issue1002 | in firefox
TEST-PASS | eq test issue1243 | in firefox
TEST-PASS | eq test issue1257 | in firefox
TEST-PASS | eq test issue1309 | in firefox
TEST-PASS | eq test issue1317 | in firefox
WARNING: no reference snapshot ref/linux2/firefox/gradientfill/1
TEST-PASS | eq test gradientfill | in firefox

OHNOES!  Some tests failed!
  different ref/snapshot: 4
Process firefox is still running. Killing.
Runtime was 1436 seconds

========== Cleaning up
./run-test: line 206: 23676 Killed                  Xvfb :1 -screen 0 1280x1024x24 > /dev/null 2> /dev/null

All done.


_____________________________ stderr:

Bot response time: 25.19 mins

Artur Adib

/botio test

pdf.js test bot
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @arturadib received. Current queue size: 1

Live output at: http://23.21.150.44:8877/17856c59e4f8949/output.txt

pdf.js test bot
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://23.21.150.44:8877/17856c59e4f8949/output.txt

Total script time: 39.24 mins

  • Lint: Passed
  • Regression tests: FAILED

Image differences available at: http://23.21.150.44:8877/17856c59e4f8949/reftest-analyzer.xhtml#web=eq.log

Yury Delendik
Collaborator

bit-rotten, new class member naming shall be used

Yury Delendik
Collaborator

blocked by #1493

Brendan Dahl
Collaborator

/botio test
@pdfjsbot test

pdf.js test bot
Collaborator

Processing command test by user brendandahl. Queue size: 0

Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4984272.txt

[bot:processed:4984272]

pdf.js test bot
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/4ecdeb6a0ae1484/output.txt

pdf.js test bot
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/4ecdeb6a0ae1484/output.txt

Total script time: 19.36 mins

  • Lint: FAILED
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/4ecdeb6a0ae1484/reftest-analyzer.xhtml#web=eq.log

pdf.js test bot
Collaborator

ERROR(s) found

ATTENTION: There was a snapshot difference:
http://184.73.87.52:8989/tests/fece736b8a14c6f6174c61b242cc804bf6b93213/reftest-analyzer.xhtml#web=/tests/fece736b8a14c6f6174c61b242cc804bf6b93213/eq.log

Output:

========== Killing any stray processes

========== Running garbage collector in /mnt/pdfjsbot-tmp
Collecting garbage...

========== Cloning pull request repo
Cloning into ....

========== Merging upstream into pull request clone

========== Running 'make lint'
gjslint --nojsdoc  src/bidi.js src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metadata.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js    web/compatibility.js web/debugger.js web/viewer.js  test/driver.js  examples/helloworld/hello.js  extensions/firefox/bootstrap.js  extensions/firefox/components/PdfStreamConverter.js    test/unit/crypto_spec.js test/unit/font_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js
----- FILE  :  /mnt/pdfjsbot-tmp/tests/fece736b8a14c6f6174c61b242cc804bf6b93213/src/pattern.js -----
Line 29, E:0110: Line too long (84 characters).

Found 1 errors, including 0 new errors, in 1 files (34 files OK).

Some of the errors reported by GJsLint may be auto-fixable using the script
fixjsstyle. Please double check any changes it makes and report any bugs. The
script can be run by executing:

fixjsstyle --nojsdoc src/bidi.js src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metadata.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js web/compatibility.js web/debugger.js web/viewer.js test/driver.js examples/helloworld/hello.js extensions/firefox/bootstrap.js extensions/firefox/components/PdfStreamConverter.js test/unit/crypto_spec.js test/unit/font_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js 
make: *** [lint] Error 1

========== Cloning reference images repo into test/ref/
Initialized empty Git repository in /mnt/pdfjsbot-tmp/tests/fece736b8a14c6f6174c61b242cc804bf6b93213/test/ref/.git/

========== Checking for consistency with reference repo

========== Running 'make bot_test'
Xvfb: no process found
cd test; \
    python -u test.py \
    --browserManifestFile=resources/browser_manifests/browser_manifest.json \
    --manifestFile=test_manifest.json
Launching firefox
Launching chrome
TEST-PASS | eq test tracemonkey-eq | in chrome
TEST-PASS | eq test tracemonkey-eq | in firefox
TEST-PASS | forward-back-forward test tracemonkey-fbf | in chrome
TEST-PASS | load test html5-canvas-cheat-sheet-load | in chrome
TEST-PASS | forward-back-forward test tracemonkey-fbf | in firefox
TEST-PASS | load test html5-canvas-cheat-sheet-load | in firefox
TEST-PASS | eq test intelisa-eq | in chrome
TEST-PASS | eq test intelisa-eq | in firefox
TEST-PASS | load test pdfspec-load | in chrome
TEST-PASS | load test shavian-load | in chrome
TEST-UNEXPECTED-FAIL | eq sizes | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test plusminus | in chrome
TEST-PASS | load test openoffice-pdf | in chrome
TEST-PASS | load test openofficecidtruetype-pdf | in chrome
TEST-PASS | load test openofficearabiccidtruetype-pdf | in chrome
TEST-PASS | load test arabiccidtruetype-pdf | in chrome
TEST-PASS | load test complexttffont-pdf | in chrome
TEST-PASS | eq test thuluthfont-pdf | in chrome
TEST-PASS | eq test freeculture | in chrome
TEST-PASS | eq test wnv_chinese-pdf | in chrome
TEST-PASS | eq test i9-pdf | in chrome
TEST-PASS | load test hmm-pdf | in chrome
TEST-PASS | eq test rotation | in chrome
TEST-PASS | load test ecma262-pdf | in chrome
TEST-PASS | load test jai-pdf | in chrome
TEST-PASS | eq test cable | in chrome
TEST-PASS | eq test pdkids | in chrome
TEST-UNEXPECTED-FAIL | eq artofwar | in chrome | rendering of page 1 != reference rendering
TEST-UNEXPECTED-FAIL | eq artofwar | in chrome | rendering of page 2 != reference rendering
TEST-UNEXPECTED-FAIL | eq artofwar | in chrome | rendering of page 3 != reference rendering
TEST-UNEXPECTED-FAIL | eq artofwar | in chrome | rendering of page 4 != reference rendering
TEST-PASS | load test pdfspec-load | in firefox
TEST-PASS | load test shavian-load | in firefox
TEST-PASS | eq test sizes | in firefox
TEST-PASS | eq test plusminus | in firefox
TEST-PASS | eq test wdsg_fitc | in chrome
TEST-PASS | load test openoffice-pdf | in firefox
TEST-PASS | load test openofficecidtruetype-pdf | in firefox
TEST-PASS | load test openofficearabiccidtruetype-pdf | in firefox
TEST-PASS | load test arabiccidtruetype-pdf | in firefox
TEST-PASS | load test complexttffont-pdf | in firefox
TEST-PASS | eq test thuluthfont-pdf | in firefox
TEST-PASS | eq test unix01 | in chrome
TEST-PASS | eq test freeculture | in firefox
TEST-PASS | eq test wnv_chinese-pdf | in firefox
TEST-PASS | eq test i9-pdf | in firefox
TEST-PASS | load test hmm-pdf | in firefox
TEST-PASS | eq test rotation | in firefox
TEST-PASS | eq test fit11-talk | in chrome
TEST-PASS | eq test fips197 | in chrome
TEST-PASS | load test txt2pdf | in chrome
TEST-PASS | load test f1040 | in chrome
TEST-PASS | load test hudsonsurvey | in chrome
TEST-PASS | eq test extgstate | in chrome
TEST-PASS | eq test usmanm-bad | in chrome
TEST-PASS | load test vesta-bad | in chrome
TEST-PASS | load test scan-bad | in chrome
TEST-PASS | load test ibwa-bad | in chrome
TEST-UNEXPECTED-FAIL | eq tcpdf_033 | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test pal-o47 | in chrome
TEST-PASS | eq test simpletype3font | in chrome
TEST-PASS | eq test close-path-bug | in chrome
TEST-PASS | eq test alphatrans | in chrome
TEST-PASS | eq test devicen | in chrome
TEST-PASS | eq test cmykjpeg | in chrome
TEST-PASS | eq test protectip | in chrome
TEST-PASS | eq test piperine | in chrome
TEST-PASS | eq test issue840 | in chrome
TEST-PASS | eq test bpl13210 | in chrome
TEST-PASS | eq test tutorial | in chrome
TEST-PASS | eq test geothermal.pdf | in chrome
TEST-PASS | eq test lista_preliminar | in chrome
TEST-PASS | eq test issue919 | in chrome
TEST-PASS | eq test issue918 | in chrome
TEST-UNEXPECTED-FAIL | eq issue1001 | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test aboutstacks | in chrome
TEST-PASS | eq test smaskdim | in chrome
TEST-PASS | eq test type4psfunc | in chrome
TEST-PASS | load test ocs | in chrome
TEST-PASS | eq test issue1010 | in chrome
TEST-PASS | load test ecma262-pdf | in firefox
TEST-PASS | eq test issue1015 | in chrome
TEST-UNEXPECTED-FAIL | eq issue1096 | in chrome | rendering of page 1 != reference rendering
TEST-PASS | eq test issue1127 | in chrome
TEST-PASS | load test issue1249-load | in chrome
TEST-PASS | load test liveprogramming | in chrome
TEST-PASS | eq test S2-eq | in chrome
TEST-PASS | eq test issue1055 | in chrome
TEST-PASS | eq test issue1169 | in chrome
TEST-PASS | eq test zerowidthline | in chrome
TEST-PASS | eq test html5checker | in chrome
TEST-PASS | eq test pdfkit_compressed | in chrome
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 1 != reference rendering
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 2 != reference rendering
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 3 != reference rendering
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 4 != reference rendering
TEST-UNEXPECTED-FAIL | eq tamreview | in chrome | rendering of page 5 != reference rendering
TEST-PASS | eq test preistabelle | in chrome
TEST-PASS | eq test issue1350 | in chrome
TEST-PASS | eq test issue925 | in chrome
TEST-PASS | eq test issue1133 | in chrome
TEST-PASS | eq test issue1049 | in chrome
TEST-PASS | eq test issue1155 | in chrome
TEST-PASS | eq test issue1002 | in chrome
TEST-PASS | eq test issue1243 | in chrome
TEST-PASS | eq test issue1257 | in chrome
TEST-PASS | eq test issue1309 | in chrome
TEST-PASS | eq test issue1317 | in chrome
WARNING: no reference snapshot ref/linux2/chrome/gradientfill/1
TEST-PASS | eq test gradientfill | in chrome
TEST-PASS | load test jai-pdf | in firefox
TEST-PASS | eq test cable | in firefox
TEST-PASS | eq test pdkids | in firefox
TEST-PASS | eq test artofwar | in firefox
TEST-PASS | eq test wdsg_fitc | in firefox
TEST-PASS | eq test unix01 | in firefox
TEST-PASS | eq test fit11-talk | in firefox
TEST-PASS | eq test fips197 | in firefox
TEST-PASS | load test txt2pdf | in firefox
TEST-PASS | load test f1040 | in firefox
TEST-PASS | load test hudsonsurvey | in firefox
TEST-PASS | eq test extgstate | in firefox
TEST-PASS | eq test usmanm-bad | in firefox
TEST-PASS | load test vesta-bad | in firefox
TEST-PASS | load test scan-bad | in firefox
TEST-PASS | load test ibwa-bad | in firefox
TEST-PASS | eq test tcpdf_033 | in firefox
TEST-PASS | eq test pal-o47 | in firefox
TEST-PASS | eq test simpletype3font | in firefox
TEST-PASS | eq test close-path-bug | in firefox
TEST-PASS | eq test alphatrans | in firefox
TEST-PASS | eq test devicen | in firefox
TEST-PASS | eq test cmykjpeg | in firefox
TEST-PASS | eq test protectip | in firefox
TEST-PASS | eq test piperine | in firefox
TEST-PASS | eq test issue840 | in firefox
TEST-PASS | eq test bpl13210 | in firefox
TEST-PASS | eq test tutorial | in firefox
TEST-PASS | eq test geothermal.pdf | in firefox
TEST-PASS | eq test lista_preliminar | in firefox
TEST-PASS | eq test issue919 | in firefox
TEST-PASS | eq test issue918 | in firefox
TEST-UNEXPECTED-FAIL | eq issue1001 | in firefox | rendering of page 1 != reference rendering
TEST-PASS | eq test aboutstacks | in firefox
TEST-PASS | eq test smaskdim | in firefox
TEST-PASS | eq test type4psfunc | in firefox
TEST-PASS | load test ocs | in firefox
TEST-PASS | eq test issue1010 | in firefox
TEST-PASS | eq test issue1015 | in firefox
TEST-PASS | eq test issue1096 | in firefox
TEST-PASS | eq test issue1127 | in firefox
TEST-PASS | load test issue1249-load | in firefox
TEST-PASS | load test liveprogramming | in firefox
TEST-PASS | eq test S2-eq | in firefox
TEST-PASS | eq test issue1055 | in firefox
TEST-PASS | eq test issue1169 | in firefox
TEST-PASS | eq test zerowidthline | in firefox
TEST-PASS | eq test html5checker | in firefox
TEST-PASS | eq test pdfkit_compressed | in firefox
TEST-PASS | eq test tamreview | in firefox
TEST-PASS | eq test preistabelle | in firefox
TEST-PASS | eq test issue1350 | in firefox
TEST-PASS | eq test issue925 | in firefox
TEST-PASS | eq test issue1133 | in firefox
TEST-PASS | eq test issue1049 | in firefox
TEST-PASS | eq test issue1155 | in firefox
TEST-PASS | eq test issue1002 | in firefox
TEST-PASS | eq test issue1243 | in firefox
TEST-PASS | eq test issue1257 | in firefox
TEST-PASS | eq test issue1309 | in firefox
TEST-PASS | eq test issue1317 | in firefox
WARNING: no reference snapshot ref/linux2/firefox/gradientfill/1
TEST-PASS | eq test gradientfill | in firefox

OHNOES!  Some tests failed!
  different ref/snapshot: 14
Process firefox is still running. Killing.
Runtime was 1423 seconds

========== Cleaning up
./run-test: line 206:  3650 Killed                  Xvfb :1 -screen 0 1280x1024x24 > /dev/null 2> /dev/null

All done.


_____________________________ stderr:

Bot response time: 24.96 mins

Brendan Dahl
Collaborator

/botio lint

pdf.js test bot
Collaborator

From: Bot.io (Windows)


Received

Command cmd_lint from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ccf50650bf0e73d/output.txt

pdf.js test bot
Collaborator

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/ccf50650bf0e73d/output.txt

Total script time: 1.07 mins

  • Lint: Passed
Yury Delendik
Collaborator

@pdfjsbot makeref
/botio makeref

pdf.js test bot
Collaborator

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ea3977543937a06/output.txt

pdf.js test bot
Collaborator

Processing command makeref by user yurydelendik. Queue size: 0

Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4987465.txt

[bot:processed:4987465]

pdf.js test bot
Collaborator

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/ea3977543937a06/output.txt

Total script time: 19.69 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed
pdf.js test bot
Collaborator

References generated

Images pushed to /mnt/pdfjsbot-ref

Output:

========== Killing any stray processes

========== Running garbage collector in /mnt/pdfjsbot-tmp
Collecting garbage...

========== Cloning pull request repo
Cloning into ....

========== Merging upstream into pull request clone
Auto-merging src/evaluator.js
Auto-merging test/test_manifest.json

========== Running 'make lint'
gjslint --nojsdoc  src/bidi.js src/canvas.js src/charsets.js src/cidmaps.js src/colorspace.js src/core.js src/crypto.js src/evaluator.js src/fonts.js src/function.js src/glyphlist.js src/image.js src/jpx.js src/metadata.js src/metrics.js src/obj.js src/parser.js src/pattern.js src/pdf.js src/stream.js src/util.js src/worker.js src/worker_loader.js    web/compatibility.js web/debugger.js web/viewer.js  test/driver.js  examples/helloworld/hello.js  extensions/firefox/bootstrap.js  extensions/firefox/components/PdfStreamConverter.js    test/unit/crypto_spec.js test/unit/font_spec.js test/unit/function_spec.js test/unit/obj_spec.js test/unit/stream_spec.js
35 files checked, no errors found.

========== Running 'make bot_master'
Xvfb: no process found
cd test && \
    python -u test.py \
    --masterMode \
    --noPrompts \
    --browserManifestFile=resources/browser_manifests/browser_manifest.json
Launching firefox
Launching chrome
TEST-PASS | eq test tracemonkey-eq | in chrome
TEST-PASS | eq test tracemonkey-eq | in firefox
TEST-PASS | forward-back-forward test tracemonkey-fbf | in chrome
TEST-PASS | load test html5-canvas-cheat-sheet-load | in chrome
TEST-PASS | forward-back-forward test tracemonkey-fbf | in firefox
TEST-PASS | load test html5-canvas-cheat-sheet-load | in firefox
TEST-PASS | eq test intelisa-eq | in chrome
TEST-PASS | eq test intelisa-eq | in firefox
TEST-PASS | load test pdfspec-load | in chrome
TEST-PASS | load test shavian-load | in chrome
TEST-PASS | eq test sizes | in chrome
TEST-PASS | eq test plusminus | in chrome
TEST-PASS | load test openoffice-pdf | in chrome
TEST-PASS | load test openofficecidtruetype-pdf | in chrome
TEST-PASS | load test openofficearabiccidtruetype-pdf | in chrome
TEST-PASS | load test arabiccidtruetype-pdf | in chrome
TEST-PASS | load test complexttffont-pdf | in chrome
TEST-PASS | eq test thuluthfont-pdf | in chrome
TEST-PASS | eq test freeculture | in chrome
TEST-PASS | eq test wnv_chinese-pdf | in chrome
TEST-PASS | eq test i9-pdf | in chrome
TEST-PASS | load test hmm-pdf | in chrome
TEST-PASS | eq test rotation | in chrome
TEST-PASS | load test ecma262-pdf | in chrome
TEST-PASS | load test jai-pdf | in chrome
TEST-PASS | eq test cable | in chrome
TEST-PASS | eq test pdkids | in chrome
TEST-PASS | eq test artofwar | in chrome
TEST-PASS | load test pdfspec-load | in firefox
TEST-PASS | load test shavian-load | in firefox
TEST-PASS | eq test sizes | in firefox
TEST-PASS | eq test plusminus | in firefox
TEST-PASS | eq test wdsg_fitc | in chrome
TEST-PASS | load test openoffice-pdf | in firefox
TEST-PASS | load test openofficecidtruetype-pdf | in firefox
TEST-PASS | load test openofficearabiccidtruetype-pdf | in firefox
TEST-PASS | load test arabiccidtruetype-pdf | in firefox
TEST-PASS | eq test unix01 | in chrome
TEST-PASS | load test complexttffont-pdf | in firefox
TEST-PASS | eq test thuluthfont-pdf | in firefox
TEST-PASS | eq test freeculture | in firefox
TEST-PASS | eq test wnv_chinese-pdf | in firefox
TEST-PASS | eq test i9-pdf | in firefox
TEST-PASS | load test hmm-pdf | in firefox
TEST-PASS | eq test rotation | in firefox
TEST-PASS | eq test fit11-talk | in chrome
TEST-PASS | eq test fips197 | in chrome
TEST-PASS | load test txt2pdf | in chrome
TEST-PASS | load test f1040 | in chrome
TEST-PASS | load test hudsonsurvey | in chrome
TEST-PASS | eq test extgstate | in chrome
TEST-PASS | eq test usmanm-bad | in chrome
TEST-PASS | load test vesta-bad | in chrome
TEST-PASS | load test scan-bad | in chrome
TEST-PASS | load test ibwa-bad | in chrome
TEST-PASS | eq test tcpdf_033 | in chrome
TEST-PASS | eq test pal-o47 | in chrome
TEST-PASS | eq test simpletype3font | in chrome
TEST-PASS | eq test close-path-bug | in chrome
TEST-PASS | eq test alphatrans | in chrome
TEST-PASS | eq test devicen | in chrome
TEST-PASS | eq test cmykjpeg | in chrome
TEST-PASS | eq test protectip | in chrome
TEST-PASS | eq test piperine | in chrome
TEST-PASS | eq test issue840 | in chrome
TEST-PASS | eq test bpl13210 | in chrome
TEST-PASS | eq test tutorial | in chrome
TEST-PASS | eq test geothermal.pdf | in chrome
TEST-PASS | eq test lista_preliminar | in chrome
TEST-PASS | eq test issue919 | in chrome
TEST-PASS | eq test issue918 | in chrome
TEST-PASS | eq test issue1001 | in chrome
TEST-PASS | eq test aboutstacks | in chrome
TEST-PASS | eq test smaskdim | in chrome
TEST-PASS | eq test type4psfunc | in chrome
TEST-PASS | load test ocs | in chrome
TEST-PASS | eq test issue1010 | in chrome
TEST-PASS | load test ecma262-pdf | in firefox
TEST-PASS | eq test issue1015 | in chrome
TEST-PASS | eq test issue1096 | in chrome
TEST-PASS | eq test issue1127 | in chrome
TEST-PASS | load test issue1249-load | in chrome
TEST-PASS | load test liveprogramming | in chrome
TEST-PASS | eq test S2-eq | in chrome
TEST-PASS | eq test issue1055 | in chrome
TEST-PASS | eq test issue1169 | in chrome
TEST-PASS | eq test zerowidthline | in chrome
TEST-PASS | eq test html5checker | in chrome
TEST-PASS | eq test pdfkit_compressed | in chrome
TEST-PASS | eq test tamreview | in chrome
TEST-PASS | eq test preistabelle | in chrome
TEST-PASS | eq test issue1350 | in chrome
TEST-PASS | eq test issue925 | in chrome
TEST-PASS | eq test issue1466 | in chrome
TEST-PASS | eq test issue1133 | in chrome
TEST-PASS | eq test issue1049 | in chrome
TEST-PASS | eq test issue1155 | in chrome
TEST-PASS | eq test issue1002 | in chrome
TEST-PASS | eq test issue1243 | in chrome
TEST-PASS | eq test issue1257 | in chrome
TEST-PASS | eq test issue1309 | in chrome
TEST-PASS | eq test issue1317 | in chrome
TEST-PASS | eq test gradientfill | in chrome
TEST-PASS | load test jai-pdf | in firefox
TEST-PASS | eq test cable | in firefox
TEST-PASS | eq test pdkids | in firefox
TEST-PASS | eq test artofwar | in firefox
TEST-PASS | eq test wdsg_fitc | in firefox
TEST-PASS | eq test unix01 | in firefox
TEST-PASS | eq test fit11-talk | in firefox
TEST-PASS | eq test fips197 | in firefox
TEST-PASS | load test txt2pdf | in firefox
TEST-PASS | load test f1040 | in firefox
TEST-PASS | load test hudsonsurvey | in firefox
TEST-PASS | eq test extgstate | in firefox
TEST-PASS | eq test usmanm-bad | in firefox
TEST-PASS | load test vesta-bad | in firefox
TEST-PASS | load test scan-bad | in firefox
TEST-PASS | load test ibwa-bad | in firefox
TEST-PASS | eq test tcpdf_033 | in firefox
TEST-PASS | eq test pal-o47 | in firefox
TEST-PASS | eq test simpletype3font | in firefox
TEST-PASS | eq test close-path-bug | in firefox
TEST-PASS | eq test alphatrans | in firefox
TEST-PASS | eq test devicen | in firefox
TEST-PASS | eq test cmykjpeg | in firefox
TEST-PASS | eq test protectip | in firefox
TEST-PASS | eq test piperine | in firefox
TEST-PASS | eq test issue840 | in firefox
TEST-PASS | eq test bpl13210 | in firefox
TEST-PASS | eq test tutorial | in firefox
TEST-PASS | eq test geothermal.pdf | in firefox
TEST-PASS | eq test lista_preliminar | in firefox
TEST-PASS | eq test issue919 | in firefox
TEST-PASS | eq test issue918 | in firefox
TEST-PASS | eq test issue1001 | in firefox
TEST-PASS | eq test aboutstacks | in firefox
TEST-PASS | eq test smaskdim | in firefox
TEST-PASS | eq test type4psfunc | in firefox
TEST-PASS | load test ocs | in firefox
TEST-PASS | eq test issue1010 | in firefox
TEST-PASS | eq test issue1015 | in firefox
TEST-PASS | eq test issue1096 | in firefox
TEST-PASS | eq test issue1127 | in firefox
TEST-PASS | load test issue1249-load | in firefox
TEST-PASS | load test liveprogramming | in firefox
TEST-PASS | eq test S2-eq | in firefox
TEST-PASS | eq test issue1055 | in firefox
TEST-PASS | eq test issue1169 | in firefox
TEST-PASS | eq test zerowidthline | in firefox
TEST-PASS | eq test html5checker | in firefox
TEST-PASS | eq test pdfkit_compressed | in firefox
TEST-PASS | eq test tamreview | in firefox
TEST-PASS | eq test preistabelle | in firefox
TEST-PASS | eq test issue1350 | in firefox
TEST-PASS | eq test issue925 | in firefox
TEST-PASS | eq test issue1466 | in firefox
TEST-PASS | eq test issue1133 | in firefox
TEST-PASS | eq test issue1049 | in firefox
TEST-PASS | eq test issue1155 | in firefox
TEST-PASS | eq test issue1002 | in firefox
TEST-PASS | eq test issue1243 | in firefox
TEST-PASS | eq test issue1257 | in firefox
TEST-PASS | eq test issue1309 | in firefox
TEST-PASS | eq test issue1317 | in firefox
TEST-PASS | eq test gradientfill | in firefox

All tests passed.
Process firefox is still running. Killing.
Runtime was 1433 seconds
Some eq tests failed or didn't have snapshots.
Checking to see if master references can be updated...
  Yes!  The references in tmp/ can be synced with ref/.
  Updating ref/ ... done
Exception in thread Thread-1 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
  File "/usr/lib/python2.7/threading.py", line 505, in run
  File "/usr/lib/python2.7/SocketServer.py", line 230, in serve_forever
  File "/usr/lib/python2.7/threading.py", line 389, in set
  File "/usr/lib/python2.7/threading.py", line 296, in notifyAll
<type 'exceptions.TypeError'>: 'NoneType' object is not callable

========== Pushing new snapshots to reference repo
Initialized empty Git repository in /mnt/pdfjsbot-tmp/tests/4984ca9894927a9483df6bbf157141842ab0f037/test/ref_repo/.git/
./run-makeref: line 190:  4013 Killed                  Xvfb :1 -screen 0 1280x1024x24 > /dev/null 2> /dev/null  (wd: /mnt/pdfjsbot-tmp/tests/4984ca9894927a9483df6bbf157141842ab0f037)
Initialized empty Git repository in /mnt/pdfjsbot-tmp/tests/4984ca9894927a9483df6bbf157141842ab0f037/test/ref_repo/.git/
To /mnt/pdfjsbot-ref
 + 775d994...36b6125 master -> master (forced update)
Running garbage collector in local git repo

========== Cleaning up

All done.


_____________________________ stderr:

Bot response time: 27.03 mins

Yury Delendik yurydelendik merged commit b10d7fc into from April 05, 2012
Yury Delendik yurydelendik closed this April 05, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
5  src/canvas.js
@@ -926,7 +926,7 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
926 926
         }
927 927
         var pattern = new TilingPattern(IR, color, this.ctx, this.objs);
928 928
       } else if (IR[0] == 'RadialAxial' || IR[0] == 'Dummy') {
929  
-        var pattern = Pattern.shadingFromIR(this.ctx, IR);
  929
+        var pattern = Pattern.shadingFromIR(IR);
930 930
       } else {
931 931
         error('Unkown IR type ' + IR[0]);
932 932
       }
@@ -1010,7 +1010,8 @@ var CanvasGraphics = (function CanvasGraphicsClosure() {
1010 1010
       var ctx = this.ctx;
1011 1011
 
1012 1012
       this.save();
1013  
-      ctx.fillStyle = Pattern.shadingFromIR(ctx, patternIR);
  1013
+      var pattern = Pattern.shadingFromIR(patternIR);
  1014
+      ctx.fillStyle = pattern.getPattern(ctx);
1014 1015
 
1015 1016
       var inv = ctx.mozCurrentTransformInverse;
1016 1017
       if (inv) {
7  src/evaluator.js
@@ -305,8 +305,8 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
305 305
                 else if (typeNum == SHADING_PATTERN) {
306 306
                   var shading = dict.get('Shading');
307 307
                   var matrix = dict.get('Matrix');
308  
-                  var pattern = Pattern.parseShading(shading, matrix, xref, res,
309  
-                                                                  null /*ctx*/);
  308
+                  var pattern = Pattern.parseShading(shading, matrix, xref,
  309
+                                                     res);
310 310
                   args = pattern.getIR();
311 311
                 } else {
312 312
                   error('Unkown PatternType ' + typeNum);
@@ -376,8 +376,7 @@ var PartialEvaluator = (function PartialEvaluatorClosure() {
376 376
               if (!shading)
377 377
                 error('No shading object found');
378 378
 
379  
-              var shadingFill = Pattern.parseShading(shading, null, xref, res,
380  
-                                                      null);
  379
+              var shadingFill = Pattern.parseShading(shading, null, xref, res);
381 380
               var patternIR = shadingFill.getIR();
382 381
               args = [patternIR];
383 382
               fn = 'shadingFill';
60  src/pattern.js
@@ -22,12 +22,12 @@ var Pattern = (function PatternClosure() {
22 22
     }
23 23
   };
24 24
 
25  
-  Pattern.shadingFromIR = function Pattern_shadingFromIR(ctx, raw) {
26  
-    return Shadings[raw[0]].fromIR(ctx, raw);
  25
+  Pattern.shadingFromIR = function Pattern_shadingFromIR(raw) {
  26
+    return Shadings[raw[0]].fromIR(raw);
27 27
   };
28 28
 
29 29
   Pattern.parseShading = function Pattern_parseShading(shading, matrix, xref,
30  
-                                                      res, ctx) {
  30
+                                                       res) {
31 31
 
32 32
     var dict = isStream(shading) ? shading.dict : shading;
33 33
     var type = dict.get('ShadingType');
@@ -36,7 +36,7 @@ var Pattern = (function PatternClosure() {
36 36
       case PatternType.AXIAL:
37 37
       case PatternType.RADIAL:
38 38
         // Both radial and axial shadings are handled by RadialAxial shading.
39  
-        return new Shadings.RadialAxial(dict, matrix, xref, res, ctx);
  39
+        return new Shadings.RadialAxial(dict, matrix, xref, res);
40 40
       default:
41 41
         return new Shadings.Dummy();
42 42
     }
@@ -101,36 +101,40 @@ Shadings.RadialAxial = (function RadialAxialClosure() {
101 101
     this.colorStops = colorStops;
102 102
   }
103 103
 
104  
-  RadialAxial.fromIR = function RadialAxial_fromIR(ctx, raw) {
  104
+  RadialAxial.fromIR = function RadialAxial_fromIR(raw) {
105 105
     var type = raw[1];
106 106
     var colorStops = raw[2];
107 107
     var p0 = raw[3];
108 108
     var p1 = raw[4];
109 109
     var r0 = raw[5];
110 110
     var r1 = raw[6];
111  
-
112  
-    var curMatrix = ctx.mozCurrentTransform;
113  
-    if (curMatrix) {
114  
-      var userMatrix = ctx.mozCurrentTransformInverse;
115  
-
116  
-      p0 = Util.applyTransform(p0, curMatrix);
117  
-      p0 = Util.applyTransform(p0, userMatrix);
118  
-
119  
-      p1 = Util.applyTransform(p1, curMatrix);
120  
-      p1 = Util.applyTransform(p1, userMatrix);
121  
-    }
122  
-
123  
-    var grad;
124  
-    if (type == PatternType.AXIAL)
125  
-      grad = ctx.createLinearGradient(p0[0], p0[1], p1[0], p1[1]);
126  
-    else if (type == PatternType.RADIAL)
127  
-      grad = ctx.createRadialGradient(p0[0], p0[1], r0, p1[0], p1[1], r1);
128  
-
129  
-    for (var i = 0, ii = colorStops.length; i < ii; ++i) {
130  
-      var c = colorStops[i];
131  
-      grad.addColorStop(c[0], c[1]);
132  
-    }
133  
-    return grad;
  111
+    return {
  112
+      type: 'Pattern',
  113
+      getPattern: function(ctx) {
  114
+        var curMatrix = ctx.mozCurrentTransform;
  115
+        if (curMatrix) {
  116
+          var userMatrix = ctx.mozCurrentTransformInverse;
  117
+
  118
+          p0 = Util.applyTransform(p0, curMatrix);
  119
+          p0 = Util.applyTransform(p0, userMatrix);
  120
+
  121
+          p1 = Util.applyTransform(p1, curMatrix);
  122
+          p1 = Util.applyTransform(p1, userMatrix);
  123
+        }
  124
+
  125
+        var grad;
  126
+        if (type == PatternType.AXIAL)
  127
+          grad = ctx.createLinearGradient(p0[0], p0[1], p1[0], p1[1]);
  128
+        else if (type == PatternType.RADIAL)
  129
+          grad = ctx.createRadialGradient(p0[0], p0[1], r0, p1[0], p1[1], r1);
  130
+
  131
+        for (var i = 0, ii = colorStops.length; i < ii; ++i) {
  132
+          var c = colorStops[i];
  133
+          grad.addColorStop(c[0], c[1]);
  134
+        }
  135
+        return grad;
  136
+      }
  137
+    };
134 138
   };
135 139
 
136 140
   RadialAxial.prototype = {
2  test/pdfs/.gitignore
@@ -30,3 +30,5 @@
30 30
 !zerowidthline.pdf
31 31
 !issue1002.pdf
32 32
 !issue925.pdf
  33
+!gradientfill.pdf
  34
+
BIN  test/pdfs/gradientfill.pdf
Binary file not shown
6  test/test_manifest.json
@@ -558,5 +558,11 @@
558 558
       "rounds": 1,
559 559
       "link": true,
560 560
       "type": "eq"
  561
+    },
  562
+    {  "id": "gradientfill",
  563
+      "file": "pdfs/gradientfill.pdf",
  564
+      "md5": "cbc1988e4803f647fa83467a85f0e231",
  565
+      "rounds": 1,
  566
+      "type": "eq"
561 567
     }
562 568
 ]
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.