New UI - work in progress #1537

Merged
merged 55 commits into from Apr 30, 2012

6 participants

@arturadib

TODO:

  • Remove print button
  • Fix/add print button
  • Restyle progress bar
  • Re-arrange the zoom options to Stephen's specs.
  • Add back the browse file button or just remove it?
  • Add disabled state for buttons?
  • I think we should change it so the outline button is never disabled, instead it should just say in italic "No outline available" or something.
  • Clean up the error message dialog

A little more out there:

  • Scroll the thumbnail view while the user scrolls the main pages.
  • Determine the page number based on the center of the screen instead of the top.
@arturadib

/botio preview

@pdfjsbot

From: Bot.io (Windows)


Received

Command cmd_preview from @arturadib received. Current queue size: 0

Live output at: http://107.22.172.223:8877/00027352df33378/output.txt

@arturadib

/botio-windows preview

@pdfjsbot

From: Bot.io (Windows)


Received

Command cmd_preview from @arturadib received. Current queue size: 0

Live output at: http://107.22.172.223:8877/db5d606cb302847/output.txt

@arturadib arturadib referenced this pull request Apr 24, 2012
Closed

[Concept] Floating ui #1469

@gigaherz

Nice :O

@arturadib

/botio-windows preview

@pdfjsbot

From: Bot.io (Windows)


Received

Command cmd_preview from @arturadib received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ddfae8de3b33bd4/output.txt

@saebekassebil

Indeed the file browser looks out of place, and so do the scrollbar. Has it been considered implementing a "custom" scroll bar, like the one you find in Google products (GMail, Google Docs, etc)? It would probably fit the overall layout better.

Is there a way to contribute to this layout with fixes, or should i just post a patch here and then let you merge it with the code if it seems reasonable?

Great piece of work! I love it.

@brendandahl

TODO:

  • Fix/add print button
  • Re-arrange the zoom options to Stephen's specs.
  • Add back the browse file button or just remove it?
  • Add disabled state for buttons?
  • I think we should change it so the outline button is never disabled, instead it should just say in italic "No outline available" or something.
  • Clean up the error message dialog

A little more out there:

  • Scroll the thumbnail view while the user scrolls the main pages.
  • Determine the page number based on the center of the screen instead of the top.
@gigaherz gigaherz commented on the diff Apr 25, 2012
web/viewer.js
@@ -62,6 +62,9 @@ var ProgressBar = (function ProgressBarClosure() {
updateBar: function ProgressBar_updateBar() {
var progressSize = this.width * this._percent / 100;
+ if (this._percent > 95)
@gigaherz
gigaherz added a line comment Apr 25, 2012

Oh hm... yeah, I suppose that works. I guess figuring out the pixel width of the bar compared to the inner size of the container and then do that only if it's less than 3 pixels apart would be too much ;P

EDIT: Actually, since it's now fixed-width (200px), that makes the inner size 198px? That means 3px from the border is approximately 98.5%, so it may be slightly better to raise the number to 98%, but I'm being pedantic, so 95% is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@arturadib

Re:printing, I'm not sure if we should have that feature enabled since it's broken (it only prints pages that have been loaded).

@yurydelendik

/botio-windows preview

@pdfjsbot

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/d18e460a6aa67f9/output.txt

@yurydelendik

/botio-windows preview

@pdfjsbot

From: Bot.io (Windows)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/04105704632ca58/output.txt

@brendandahl

/botio preview

@pdfjsbot

From: Bot.io (Windows)


Received

Command cmd_preview from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9b6a6b21ced7887/output.txt

@pdfjsbot

From: Bot.io (Linux)


Received

Command cmd_preview from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/4c94496b833fc58/output.txt

@yurydelendik

/botio lint

@pdfjsbot

From: Bot.io (Linux)


Received

Command cmd_lint from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2ef708be9d9f02d/output.txt

@pdfjsbot

From: Bot.io (Windows)


Received

Command cmd_lint from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/66ae49f45c318d6/output.txt

@pdfjsbot

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/2ef708be9d9f02d/output.txt

Total script time: 1.11 mins

  • Lint: Passed
@pdfjsbot

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/66ae49f45c318d6/output.txt

Total script time: 1.13 mins

  • Lint: Passed
@brendandahl

/botio-linux preivew

@pdfjsbot

From: Bot.io (Linux)


Invalid

Command not implemented: preivew.

@brendandahl

/botio-linux preview

@pdfjsbot

From: Bot.io (Linux)


Received

Command cmd_preview from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/53a418901eafa7f/output.txt

@yurydelendik yurydelendik merged commit bd440ef into master Apr 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment