Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property chain orders of Operators in isDotExpression #15486

Merged
merged 1 commit into from Sep 25, 2022
Merged

Fix property chain orders of Operators in isDotExpression #15486

merged 1 commit into from Sep 25, 2022

Conversation

nmtigor
Copy link
Contributor

@nmtigor nmtigor commented Sep 21, 2022

There is no property id for Operators, and number id has no operator properties dot, dotHash, lt, or. (see Operators.lt.id in getOperatorOrValue() below)

@timvandermeij
Copy link
Contributor

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2cd2c4368bf0812/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @timvandermeij received. Current queue size: 3

Live output at: http://54.193.163.58:8877/c38bdc39ec7f1bb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/2cd2c4368bf0812/output.txt

Total script time: 3.08 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/c38bdc39ec7f1bb/output.txt

Total script time: 10.40 mins

  • Unit Tests: Passed

@timvandermeij
Copy link
Contributor

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/667569a76c1e596/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/757eff5b21cc9fb/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/757eff5b21cc9fb/output.txt

Total script time: 5.06 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/667569a76c1e596/output.txt

Total script time: 12.15 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor

/botio-windows integrationtest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/09c5cb8660b3b1d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/09c5cb8660b3b1d/output.txt

Total script time: 11.81 mins

  • Integration Tests: FAILED

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you for doing that.

@calixteman calixteman merged commit da1780f into mozilla:master Sep 25, 2022
@nmtigor nmtigor deleted the fix_orders_of_prop branch September 25, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants