Check OffscreenCanvas support once on the worker-thread
#16095
Conversation
Currently we repeat the `FeatureTest.isOffscreenCanvasSupported` checks all over the worker-thread code, and with upcoming changes this will become even "worse". Hence this patch, which changes the *worker-thread* default value for the `isOffscreenCanvasSupported`-parameter to `false` and moves the feature-testing into the `BasePdfManager`-constructor. *Please note:* This patch is written using the GitHub UI, since I'm currently without a dev machine, so hopefully it works correctly.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3a5edd57ae3b95a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/35f15476624eb96/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/35f15476624eb96/output.txt Total script time: 13.63 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3a5edd57ae3b95a/output.txt Total script time: 25.90 mins
Image differences available at: http://54.241.84.105:8877/3a5edd57ae3b95a/reftest-analyzer.html#web=eq.log |
|
/botio-windows browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a26e92d0021ee33/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a26e92d0021ee33/output.txt Total script time: 23.22 mins
Image differences available at: http://54.193.163.58:8877/a26e92d0021ee33/reftest-analyzer.html#web=eq.log |
Currently we repeat the
FeatureTest.isOffscreenCanvasSupportedchecks all over the worker-thread code, and with upcoming changes this will become even "worse".Hence this patch, which changes the worker-thread default value for the
isOffscreenCanvasSupported-parameter tofalseand moves the feature-testing into theBasePdfManager-constructor.Please note: This patch is written using the GitHub UI, since I'm currently without a dev machine, so hopefully it works correctly.