Disable the "copy all text" feature when enablePermissions is set (PR 16286 follow-up)

[Snuffleupagus]

When permissions are enabled and the PDF document doesn't have the COPY-flag set, it shouldn't be possible for the user to trigger the "copy all text" feature.

[calixteman]

LGTM.

[calixteman]

Oh I missed the draft status.

[Snuffleupagus]

Oh I missed the draft status.

The GENERIC viewer can open more than one document, which I obviously forgot about initially; please check the updated patch.

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2252a9f348c769e/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5ff794d786c6f03/output.txt

[calixteman]

Do you plane to disable copy here too:
https://github.com/mozilla/pdf.js/blob/master/web/text_layer_builder.js#L217 ?

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/5ff794d786c6f03/output.txt

Total script time: 4.16 mins

• Integration Tests: Passed

[Snuffleupagus]

Do you plane to disable copy here too:
https://github.com/mozilla/pdf.js/blob/master/web/text_layer_builder.js#L217 ?

I don't believe that we need to, since we have CSS rules that prevent user-selection.

pdf.js/web/pdf_viewer.css

Lines 196 to 199 in 3e292dc

	.pdfViewer.enablePermissions .textLayer span {
	user-select: none !important;
	cursor: not-allowed;
	}

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/2252a9f348c769e/output.txt

Total script time: 22.53 mins

• Integration Tests: FAILED

[calixteman]

Do you plane to disable copy here too:
https://github.com/mozilla/pdf.js/blob/master/web/text_layer_builder.js#L217 ?

I don't believe that we need to, since we have CSS rules that prevent user-selection.

pdf.js/web/pdf_viewer.css

Lines 196 to 199 in 3e292dc

	.pdfViewer.enablePermissions .textLayer span {
	user-select: none !important;
	cursor: not-allowed;
	}

After having thinking about that, I think it could be useful to be able to select the text (for example when the user wants to show something to someone else) even if the copy is disabled (I personally already have been in such a situation and it was a bit painful). So I'd inclined to remove the CSS rule and disable the copy in the copy listener. Wdyt ?
When the pdf doesn't have the full permissions, maybe we should display an icon in the toolbar (like a lock or something like that) with a tooltip indication what the permissions are. And when the user try to copy when he isn't allowed to, then we could highlight this icon... or something like that.

[Snuffleupagus]

After having thinking about that, I think it could be useful to be able to select the text (for example when the user wants to show something to someone else) even if the copy is disabled (I personally already have been in such a situation and it was a bit painful). So I'd inclined to remove the CSS rule and disable the copy in the copy listener. Wdyt ?

Sure, we could implement it like that without too much trouble I think; I'll submit a patch for this later.

When the pdf doesn't have the full permissions, maybe we should display an icon in the toolbar (like a lock or something like that) with a tooltip indication what the permissions are. And when the user try to copy when he isn't allowed to, then we could highlight this icon... or something like that.

In Adobe Reader there's an additional sidebar-view in protected documents, but given that we ignore permissions by default that feels like a slightly too "heavy" solution in the PDF.js viewer. Your idea about an additional toolbarButton with a tooltip sounds simpler, although we'd probably need a couple of new l10n-strings for that.
Also, this part definitely feels like something where having UX input before we start coding would help.