Clear the full SMask scratch canvas in compose()#21277
Conversation
PR mozilla#21101 narrowed `compose()`'s `clearRect` from full canvas to the caller-supplied dirty box. That leaves pixels outside the current dirty box on the SMask scratch canvas between `compose()` calls; subsequent draws into scratch are then source-over-blended on top of those leftovers, so the output depends on the cumulative draw history rather than just the current draw.
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/06fd0c2aeb74a2d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c169a14719a2e00/output.txt |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21277 +/- ##
===========================================
+ Coverage 57.70% 80.92% +23.21%
===========================================
Files 220 254 +34
Lines 59236 64860 +5624
===========================================
+ Hits 34183 52485 +18302
+ Misses 25053 12375 -12678
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/06fd0c2aeb74a2d/output.txt Total script time: 18.32 mins
Image differences available at: http://54.241.84.105:8877/06fd0c2aeb74a2d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c169a14719a2e00/output.txt Total script time: 24.79 mins
Image differences available at: http://54.193.163.58:8877/c169a14719a2e00/reftest-analyzer.html#web=eq.log |
|
Thank you for fixing this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a6e85c9e190b389/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d5cd4440f4f9498/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a6e85c9e190b389/output.txt Total script time: 18.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d5cd4440f4f9498/output.txt Total script time: 24.61 mins
|
4 participants
PR #21101 narrowed
compose()'sclearRectfrom full canvas to the caller-supplied dirty box. That leaves pixels outside the current dirty box on the SMask scratch canvas betweencompose()calls; subsequent draws into scratch are then source-over-blended on top of those leftovers, so the output depends on the cumulative draw history rather than just the current draw.