Skip to content

Introduce integration tests for the presentation mode functionality#21292

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
timvandermeij:presentation-mode
May 19, 2026
Merged

Introduce integration tests for the presentation mode functionality#21292
Snuffleupagus merged 1 commit into
mozilla:masterfrom
timvandermeij:presentation-mode

Conversation

@timvandermeij
Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij commented May 17, 2026

This commit provides coverage for the happy flows of basic operations like entering/exiting and changing pages.

@timvandermeij timvandermeij requested a review from calixteman May 17, 2026 18:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (00af759) to head (0d69cc4).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21292      +/-   ##
==========================================
+ Coverage   81.01%   81.27%   +0.25%     
==========================================
  Files         256      256              
  Lines       64873    64873              
==========================================
+ Hits        52559    52727     +168     
+ Misses      12314    12146     -168
Flag Coverage Δ
integrationtest 66.78% <ø> (+0.27%) ⬆️
unittestcli 56.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Snuffleupagus
Snuffleupagus reviewed May 17, 2026
View reviewed changes
Comment thread test/integration/presentation_mode_spec.mjs Outdated
Snuffleupagus
Snuffleupagus reviewed May 17, 2026
View reviewed changes
Comment thread test/integration/presentation_mode_spec.mjs Outdated
@timvandermeij timvandermeij marked this pull request as draft May 17, 2026 19:04
@timvandermeij timvandermeij removed the request for review from calixteman May 17, 2026 20:12
@timvandermeij
Introduce integration tests for the presentation mode functionality
0d69cc4 
This commit provides coverage for the happy flows of basic operations
like entering/exiting and changing pages.
Snuffleupagus
Snuffleupagus approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, this seems to cover all basic functionality nicely; thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timvandermeij @codecov-commenter @Snuffleupagus