Fix scrolling using Shift+Spacebar in Firefox #4393

Merged
merged 1 commit into from Mar 6, 2014

Conversation

Projects
None yet
3 participants
@Snuffleupagus
Contributor

Snuffleupagus commented Mar 5, 2014

After #4224, scrolling using Shift + Spacebar doesn't work in Firefox, unless another navigation key was pressed before it.

@Snuffleupagus

This comment has been minimized.

Show comment Hide comment
@Snuffleupagus

Snuffleupagus Mar 5, 2014

Contributor

/botio-windows preview

Contributor

Snuffleupagus commented Mar 5, 2014

/botio-windows preview

@pdfjsbot

This comment has been minimized.

Show comment Hide comment
@pdfjsbot

pdfjsbot Mar 5, 2014

Collaborator

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2e4d9eff0776492/output.txt

Collaborator

pdfjsbot commented Mar 5, 2014

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2e4d9eff0776492/output.txt

@yurydelendik

View changes

web/viewer.js
+ // 32=Spacebar
+ if (evt.keyCode === 32 && curElementTagName !== 'BUTTON') {
+//#if (FIREFOX || MOZCENTRAL)
+// // Workaround for issue in Firefox, that prevents scroll keys from working

This comment has been minimized.

Show comment Hide comment
@yurydelendik

yurydelendik Mar 6, 2014

Contributor

could you move 'working' on the next line?

@yurydelendik

yurydelendik Mar 6, 2014

Contributor

could you move 'working' on the next line?

This comment has been minimized.

Show comment Hide comment
@Snuffleupagus

Snuffleupagus Mar 6, 2014

Contributor

Done.

@Snuffleupagus

Snuffleupagus Mar 6, 2014

Contributor

Done.

yurydelendik added a commit that referenced this pull request Mar 6, 2014

Merge pull request #4393 from Snuffleupagus/issue-4341-followup
Fix scrolling using Shift+Spacebar in Firefox

@yurydelendik yurydelendik merged commit b82af51 into mozilla:master Mar 6, 2014

1 check passed

default The Travis CI build passed
Details
@yurydelendik

This comment has been minimized.

Show comment Hide comment
@yurydelendik

yurydelendik Mar 6, 2014

Contributor

thanks

Contributor

yurydelendik commented Mar 6, 2014

thanks

@Snuffleupagus Snuffleupagus deleted the Snuffleupagus:issue-4341-followup branch Mar 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment