Add braces to single line statements in src/shared #4414

Merged
merged 5 commits into from Mar 8, 2014

Conversation

Projects
None yet
3 participants
Member

Snuffleupagus commented Mar 8, 2014

This PR fixes the coding style in the src/shared folder.
Note that this only includes adding braces to single line statements, since also changing to strict equalities/inequalities is much more difficult (because of the risk of implicit type conversion in the current code).

Contributor

timvandermeij commented Mar 8, 2014

/botio test

Collaborator

pdfjsbot commented Mar 8, 2014

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d0647d4dabd38c2/output.txt

Collaborator

pdfjsbot commented Mar 8, 2014

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f7e5843205efdba/output.txt

Collaborator

pdfjsbot commented Mar 8, 2014

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/d0647d4dabd38c2/output.txt

Total script time: 25.33 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed
Collaborator

pdfjsbot commented Mar 8, 2014

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/f7e5843205efdba/output.txt

Total script time: 35.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/f7e5843205efdba/reftest-analyzer.html#web=eq.log

timvandermeij added a commit that referenced this pull request Mar 8, 2014

Merge pull request #4414 from Snuffleupagus/src-shared-braces
Add braces to single line statements in src/shared

@timvandermeij timvandermeij merged commit df2248d into mozilla:master Mar 8, 2014

1 check passed

default The Travis CI build passed
Details

@Snuffleupagus Snuffleupagus deleted the Snuffleupagus:src-shared-braces branch Mar 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment