Skip to content

Cache pages at the start of drawing, not the end. #4932

Merged
merged 1 commit into from Jun 13, 2014

4 participants

@nnethercote

When we finish drawing a PageView, we add it to the PageView cache (this happens within the pageViewDrawCallback function within PageView.draw()). Once in the cache, it will be destroyed (via PageView.destroy()), once 20 more PageViews have been drawn, and its canvas memory can then be freed.

This is good, except it falls down in one case: when scrolling really quickly through a document, we start drawing each page but then usually move past it before it finishes drawing. When this happen, its drawing pauses because it's no longer the highest-priority page (this happens within renderContext.continueCallback in PageView.draw()).

At this point such a page is not in the cache, so it can't be destroyed. If you scroll quickly through a lot of pages, most of them will end up in this state. The only way such a page can be destroyed is by navigating back to it, whereupon its drawing will resume (within PDFView.renderView) and complete, and
it will be put into the cache.

(Now, it appears that the browser can free the canvas memory even if the page isn't destroyed. But in Firefox, this apparently doens't happen until the canvas memory has been unused for 10s of seconds, and it's very easy for canvas memory consumption to spike massively in that time.)

Fortunately, there's an easy way to fix this: just put each page in the cache as soon as it starts drawing, instead of when it finishes drawing.

This makes a big difference in practice. Scrolling through three large documents on my Mac, peak RSS dropped greatly:

  • tele: ~3000 MiB --> ~930 MiB
  • ML: ~5700 MiB --> ~1460 MiB
  • book: ~7600 MiB --> ~1360 MiB
@Snuffleupagus
Mozilla member

/botio-windows preview

@pdfjsbot

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/63e9de9c76872a2/output.txt

@yurydelendik

Thank you for the patch

@yurydelendik yurydelendik merged commit 97560ef into mozilla:master Jun 13, 2014

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
@nnethercote nnethercote deleted the nnethercote:cache-pages-earlier branch Jun 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.