Halve the size of the PageView cache. #4937

Merged
merged 1 commit into from Jun 13, 2014

Projects

None yet

2 participants

@nnethercote
Contributor

The PageView cache currently has a max size of 20. That seems overly generous. This patch reduces it to 10.

On my MacBook with a retina screen, the canvas for each page is typically about 22 MiB, so this reduces peak memory usage by 10 x 22 = 220 MiB. On my Linux desktop it's about 5.5 MiB per page, so it saves 10 x 5.5 = 55 MiB.

@yurydelendik
Contributor

Yeah, I wanted to do that long ago too.

@yurydelendik yurydelendik merged commit 7377598 into mozilla:master Jun 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@nnethercote
Contributor

Thanks for all the fast responses you've given me in the past 24 hours! :)

@nnethercote nnethercote deleted the nnethercote:smaller-cache branch Jun 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment