Rename annotation_layer_spec.js to annotation_spec.js to better describe what is actually tested, and simplify the FileAttachmentAnnotation unit-test to avoid having to use the entire API in the test
#7951
Conversation
…nit-tests only cover `src/core/annotation.js` functionality
…use the entire API in the test Every other unit-test in `annotation_spec.js` is already only testing the annotation code. Hence it seems unnecessarily convoluted to make use of the API here, when we can (fairly) simply provide the necessary data explicitly as in all the other annotation unit-test.
Snuffleupagus
changed the title
FileAttachmentAnnotation unit-test to avoid having to use the entire API in the testannotation_layer_spec.js to annotation_spec.js to better describe what is actually tested, and simplify the FileAttachmentAnnotation unit-test to avoid having to use the entire API in the test
Good call on the file name, and the fact that /botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/10dea6062d55a2a/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/65460847de6ff5f/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/65460847de6ff5f/output.txt Total script time: 2.00 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/10dea6062d55a2a/output.txt Total script time: 2.70 mins
|
|
Thank you for the patch. |
Snuffleupagus
deleted the
FileAttachmentAnnotation-simplified-unittest
branch
…tation-simplified-unittest Rename `annotation_layer_spec.js` to `annotation_spec.js` to better describe what is actually tested, and simplify the `FileAttachmentAnnotation` unit-test to avoid having to use the entire API in the test
Every other unit-test in
annotation_spec.jsis already only testing the annotation code. Hence it seems unnecessarily convoluted to make use of the API here, when we can (fairly) simply provide the necessary data explicitly as in all the other annotation unit-test.Edit: Note how doing this will also allow us to run the annotation unit-tests on Travis!
Compare the run with this PR: https://travis-ci.org/mozilla/pdf.js/builds/191392213#L369; with a previous run: https://travis-ci.org/mozilla/pdf.js/builds/191349139#L350.