Fix error when using custom CMapReaderFactory #8567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghetolay
force-pushed
the
fix_CMapReaderFactory+worker
branch
from
0d40d85
to
7f79e12
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/b86f747666898f4/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/db07b0482b9bf31/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/db07b0482b9bf31/output.txt Total script time: 16.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/b86f747666898f4/output.txt Total script time: 29.97 mins
|
|
Thank you for the patch. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…orker Fix error when using custom CMapReaderFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a source object on
getDocument()with a customCMapReaderFactorywe end up sending that factory to the worker as part of the message. This causespostMessage()to throw because it can't clone a function.So the param object passed to
_fetchDocument()shouldn't have that factory as part of his properties.It's really trivial so I didn't add test but I could build something if you want.