Update packages #9576

timvandermeij · 2018-03-17T19:24:57Z

Jasmine had a major version bump and required a few minor changes in our booting code. Most notably, using pending in a describe block is no longer supported, so we can only return early there. On the positive side, the unit tests now run in a random order by default, which eliminates any dependencies between unit tests.

Note that upgrading to Webpack 4 is out of scope for this patch since the bots cannot work well with the newly generated bundles (both browsers on both bots do not react within 120 seconds). Webpack 4 is not faster for us than Webpack 3, so for now there is no need to upgrade.

Snuffleupagus · 2018-03-18T11:59:07Z

test/unit/jasmine-boot.js

-                      true : catchingExceptions);
+  var stoppingOnSpecFailure = queryString.getParam('failFast');
+  env.stopOnSpecFailure(typeof stoppingOnSpecFailure === 'undefined' ?
+                        true : stoppingOnSpecFailure);


From a cursory look at jasmine/jasmine@e15f273, which necessitated this change, shouldn't the default now be false instead here?

Edit: Or do we perhaps not want to maintain the old behaviour here?

I have fixed these comments in the new commit. Good catch!

Snuffleupagus · 2018-03-18T12:00:09Z

test/font/jasmine-boot.js

-                      true : catchingExceptions);
+  var stoppingOnSpecFailure = queryString.getParam('failFast');
+  env.stopOnSpecFailure(typeof stoppingOnSpecFailure === 'undefined' ?
+                        true : stoppingOnSpecFailure);


From a cursory look at jasmine/jasmine@e15f273, which necessitated this change, shouldn't the default now be false instead here?

Edit: Or do we perhaps not want to maintain the old behaviour here?

Snuffleupagus · 2018-03-18T12:01:21Z

test/font/jasmine-boot.js

-      queryString.navigateWithNewParam('catch', !env.catchingExceptions());
+    onStopExecutionClick() {
+      queryString.navigateWithNewParam('failFast',
+                                       !env.stoppingOnSpecFailure());


Re above, shouldn't this also be inverted?

Snuffleupagus · 2018-03-18T12:01:32Z

test/unit/jasmine-boot.js

-      queryString.navigateWithNewParam('catch', !env.catchingExceptions());
+    onStopExecutionClick() {
+      queryString.navigateWithNewParam('failFast',
+                                       !env.stoppingOnSpecFailure());


Re above, shouldn't this also be inverted?

timvandermeij · 2018-03-18T16:35:32Z

/botio-linux preview

timvandermeij · 2018-03-18T16:40:40Z

/botio test

timvandermeij · 2018-03-18T17:54:40Z

/botio test

timvandermeij · 2018-03-18T18:13:49Z

/botio-linux preview

timvandermeij · 2018-03-18T18:17:36Z

/botio test

Snuffleupagus · 2018-03-18T21:09:01Z

Most notably, using pending in a describe block is no longer supported, so we can only return early there.

In that case, I wonder if the best solution wouldn't be to move those pending instances into each of the affected it blocks instead?
Obviously having to do that is a bit unfortunate, but I think it's conceptually the "right" solution since just returning doesn't provide a good indication that tests were skipped.

Snuffleupagus · 2018-03-19T12:00:25Z

test/unit/api_spec.js

@@ -1192,7 +1193,8 @@ describe('api', function() {
  });
  describe('Multiple PDFJS instances', function() {


Also while you're here, let's update the name to Multiple getDocument instances (which I overlooked when removing the global PDFJS object).

Snuffleupagus · 2018-03-24T19:18:53Z

package.json

-    "eslint-plugin-mozilla": "^0.9.0",
+    "escodegen": "^1.9.1",
+    "eslint": "^4.19.0",
+    "eslint-plugin-mozilla": "^0.9.1",


There's apparently an even newer version, 0.10.0, of this package now.

Snuffleupagus

Looks good to me with the final comments, especially #9576 (comment), addressed; thank you!

Jasmine had a major version bump and required a few minor changes in our booting code. Most notably, using `pending` in a `describe` block is no longer supported, so we can only return early there. On the positive side, the unit tests now run in a random order by default, which eliminates any dependencies between unit tests. Note that upgrading to Webpack 4 is out of scope for this patch since the bots cannot work well with the newly generated bundles (both browsers on both bots do not react within 120 seconds). Webpack 4 is not faster for us than Webpack 3, so for now there is no need to upgrade.

timvandermeij · 2018-03-25T15:04:58Z

/botio-linux preview

pdfjsbot · 2018-03-25T15:04:59Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/146030089d003af/output.txt

pdfjsbot · 2018-03-25T15:07:39Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/146030089d003af/output.txt

Total script time: 2.65 mins

Published

timvandermeij · 2018-03-25T15:07:55Z

/botio test

pdfjsbot · 2018-03-25T15:07:56Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8b04c985d647ad1/output.txt

pdfjsbot · 2018-03-25T15:07:56Z

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/af9ae44db84dcfd/output.txt

pdfjsbot · 2018-03-25T15:26:11Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/8b04c985d647ad1/output.txt

Total script time: 18.24 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/8b04c985d647ad1/reftest-analyzer.html#web=eq.log

pdfjsbot · 2018-03-25T15:32:05Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/af9ae44db84dcfd/output.txt

Total script time: 24.15 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

timvandermeij · 2018-03-25T15:35:16Z

Firefox on Linux had an update, but there are no visual differences.

/botio-linux makeref

pdfjsbot · 2018-03-25T15:35:17Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/24a94fef5939c08/output.txt

pdfjsbot · 2018-03-25T15:52:16Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/24a94fef5939c08/output.txt

Total script time: 16.97 mins

Lint: Passed
Make references: Passed
Check references: Passed

Update packages

timvandermeij added the other label Mar 17, 2018

Snuffleupagus reviewed Mar 18, 2018

View reviewed changes

timvandermeij force-pushed the versions branch from b1c3a3b to a573a33 Compare March 18, 2018 16:20

timvandermeij changed the title ~~Upgrade packages to their latest versions~~ Update packages Mar 18, 2018

timvandermeij force-pushed the versions branch from a573a33 to f1f674c Compare March 18, 2018 16:33

timvandermeij force-pushed the versions branch from f1f674c to 8144a8d Compare March 18, 2018 18:07

mozilla deleted a comment from pdfjsbot Mar 18, 2018

Snuffleupagus reviewed Mar 19, 2018

View reviewed changes

Snuffleupagus reviewed Mar 24, 2018

View reviewed changes

Snuffleupagus approved these changes Mar 24, 2018

View reviewed changes

timvandermeij force-pushed the versions branch from 8144a8d to 95de23e Compare March 25, 2018 15:00

mozilla deleted a comment from pdfjsbot Mar 25, 2018

timvandermeij merged commit 6cc0efe into mozilla:master Mar 25, 2018

timvandermeij deleted the versions branch March 25, 2018 15:52

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018

Merge pull request mozilla#9576 from timvandermeij/versions

4f8f458

Update packages

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update packages #9576

Update packages #9576

timvandermeij commented Mar 17, 2018 •

edited

Snuffleupagus Mar 18, 2018 •

edited

timvandermeij Mar 18, 2018

Snuffleupagus Mar 18, 2018 •

edited

Snuffleupagus Mar 18, 2018

Snuffleupagus Mar 18, 2018

timvandermeij commented Mar 18, 2018

timvandermeij commented Mar 18, 2018

timvandermeij commented Mar 18, 2018

timvandermeij commented Mar 18, 2018

timvandermeij commented Mar 18, 2018

Snuffleupagus commented Mar 18, 2018 •

edited

Snuffleupagus Mar 19, 2018

Snuffleupagus Mar 24, 2018 •

edited

Snuffleupagus left a comment •

edited

timvandermeij commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

timvandermeij commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

timvandermeij commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

		@@ -1192,7 +1193,8 @@ describe('api', function() {
		});
		describe('Multiple PDFJS instances', function() {

Update packages #9576

Update packages #9576

Conversation

timvandermeij commented Mar 17, 2018 • edited

Snuffleupagus Mar 18, 2018 • edited

Choose a reason for hiding this comment

timvandermeij Mar 18, 2018

Choose a reason for hiding this comment

Snuffleupagus Mar 18, 2018 • edited

Choose a reason for hiding this comment

Snuffleupagus Mar 18, 2018

Choose a reason for hiding this comment

Snuffleupagus Mar 18, 2018

Choose a reason for hiding this comment

timvandermeij commented Mar 18, 2018

timvandermeij commented Mar 18, 2018

timvandermeij commented Mar 18, 2018

timvandermeij commented Mar 18, 2018

timvandermeij commented Mar 18, 2018

Snuffleupagus commented Mar 18, 2018 • edited

Snuffleupagus Mar 19, 2018

Choose a reason for hiding this comment

Snuffleupagus Mar 24, 2018 • edited

Choose a reason for hiding this comment

Snuffleupagus left a comment • edited

Choose a reason for hiding this comment

timvandermeij commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Mar 25, 2018

From: Bot.io (Linux m4)

Success

Published

timvandermeij commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Mar 25, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Mar 25, 2018

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Mar 25, 2018

From: Bot.io (Windows)

Success

timvandermeij commented Mar 25, 2018

pdfjsbot commented Mar 25, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Mar 25, 2018

From: Bot.io (Linux m4)

Success

timvandermeij commented Mar 17, 2018 •

edited

Snuffleupagus Mar 18, 2018 •

edited

Snuffleupagus Mar 18, 2018 •

edited

Snuffleupagus commented Mar 18, 2018 •

edited

Snuffleupagus Mar 24, 2018 •

edited

Snuffleupagus left a comment •

edited