New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase color stop index for transparent edges. #9971
Conversation
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a3f8ad437bbb3f2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0e1d8bcd72e8cc8/output.txt |
The current number is too small for chrome and causes issues.
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/a3f8ad437bbb3f2/output.txt Total script time: 29.07 mins
Image differences available at: http://54.215.176.217:8877/a3f8ad437bbb3f2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/0e1d8bcd72e8cc8/output.txt Total script time: 35.90 mins
Image differences available at: http://54.67.70.0:8877/0e1d8bcd72e8cc8/reftest-analyzer.html#web=eq.log |
If anyone wants to play with this further...try out https://codepen.io/anon/pen/xJQXRJ and adjust the 2nd and 2nd to last color stops. |
I was talking with Patrick and he mentioned the values are probably getting packed into a byte hence 254/255 = 0.996 so above .996 gets rounded to 1. |
We should also test if this is actually an issue on the bots since they may not be using skia gl. |
@brendandahl I notice some small regressions in the reference test results. Do you want to continue this PR or should it be revisited? |
Closing since the underlying ticket is resolved by an upstream fix. |
The current number is too small for chrome and causes issues.
Fixes #9664