Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase color stop index for transparent edges. #9971

Closed
wants to merge 1 commit into from

Conversation

brendandahl
Copy link
Contributor

The current number is too small for chrome and causes issues.

Fixes #9664

@brendandahl
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2018

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/a3f8ad437bbb3f2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2018

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/0e1d8bcd72e8cc8/output.txt

The current number is too small for chrome and causes issues.
@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2018

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/a3f8ad437bbb3f2/output.txt

Total script time: 29.07 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/a3f8ad437bbb3f2/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Aug 8, 2018

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/0e1d8bcd72e8cc8/output.txt

Total script time: 35.90 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/0e1d8bcd72e8cc8/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor Author

If anyone wants to play with this further...try out https://codepen.io/anon/pen/xJQXRJ and adjust the 2nd and 2nd to last color stops.

@brendandahl
Copy link
Contributor Author

I was talking with Patrick and he mentioned the values are probably getting packed into a byte hence 254/255 = 0.996 so above .996 gets rounded to 1.

@brendandahl
Copy link
Contributor Author

We should also test if this is actually an issue on the bots since they may not be using skia gl.

@timvandermeij
Copy link
Contributor

@brendandahl I notice some small regressions in the reference test results. Do you want to continue this PR or should it be revisited?

@timvandermeij
Copy link
Contributor

Closing since the underlying ticket is resolved by an upstream fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specific pdf file is not rendered correctly in Chrome
3 participants