This repository has been archived by the owner. It is now read-only.

Use cachify for css and js links. Fixes Issue #93 #96

Merged
merged 3 commits into from Oct 15, 2012

Conversation

Projects
None yet
2 participants
Member

ozten commented Oct 15, 2012

  • Fix unit tests
  • Adds NODE_ENV to control development vs production
Use cachify for css and js links. Fixes Issue #93
* Fix unit tests
* Adds NODE_ENV to control development vs production

@ghost ghost assigned callahad Oct 15, 2012

Owner

callahad commented Oct 15, 2012

+1 LGTM, issue #97 notwithstanding. I'll fix #97 then reassign the PR to you to merge.

@ghost ghost assigned ozten Oct 15, 2012

Member

ozten commented on static/css/ie8.css in 857fe41 Oct 15, 2012

This is our source code for i8.css, so we should keep it in the tree.

In development mode, HTML will spit out /css/ie8.css and in production mode it will spit out /v/90ad8fad0f98/css/ie8.min.css

Owner

callahad replied Oct 15, 2012

But we don't/shouldn't use ie8.css at all, as far as I can tell. See #97.

Nothing should be spitting out / using this thing, right?

+ env: {
+ doc: "What environment are we running in? Note: all hosted environments are 'production'. ",
+ format: 'string ["production", "development"] = "production"',
+ env: 'NODE_ENV'
@ozten

ozten Oct 15, 2012

Member

So Bigtent now respects NODE_ENV which can be set to production or development.

This can be changed in local.json with

...
"env": "development",
...

The default for this setting is production mode.

In development mode, a page will render links to the original sources.

In production mode, a page will render a link to the minified source. Cache urls will be created to improve performance.

Owner

callahad commented Oct 15, 2012

Commit 4739e8e ("Adding missed commit for button-arrow.png") should be reverted. The previous commit, 857fe4, removes the only stylesheet that references that image. It's dead code.

Edit: Reverted, re-pushed with --force so it doesn't show up in this history anymore.

Owner

callahad commented Oct 15, 2012

Rebase and repush complete.

@ozten Back to you to review / merge.

Member

ozten commented Oct 15, 2012

THanks for the review and rebase.

ozten added a commit that referenced this pull request Oct 15, 2012

Merge pull request #96 from mozilla/issue-93-cachify-assets
Use cachify for css and js links. Fixes Issue #93

@ozten ozten merged commit c9d16a6 into master Oct 15, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.