This repository has been archived by the owner. It is now read-only.

completing registration in a browser other than the initiating browser results in non-functional dialog #1026

Closed
shane-tomlinson opened this Issue Feb 1, 2012 · 8 comments

Comments

Projects
None yet
3 participants
Member

shane-tomlinson commented Feb 1, 2012

Steps to reproduce

  1. Open up two browsers
  2. In browser 1, go to beta.myfavoritebeer.org
  3. Sign up for a new account
  4. Keep dialog open
  5. In browser 2, open email provider
  6. Open verification link in browser 2
  7. Enter passwords and complete flow.
  8. Original dialog goes back to authentication screen, but buttons are unresponsive.

Desired result.

User needs to authenticate.

@ghost ghost assigned shane-tomlinson Feb 1, 2012

Contributor

jbonacci commented Feb 1, 2012

I have had clunky behavior using two browsers for this work (especially on mobile). See the separate issues file.
But this sounds like a regression.

shane-tomlinson added a commit that referenced this issue Feb 1, 2012

Fixing the complete registration flow when the browser the user compl…
…etes registration is different from the one they started at.

* in check_registration.js, the "auth" message has been changed to "authenticate"
* in user.js, when the registration poll completes, set the "known" field of the address in the addressInfo cache to "true"

issue #1026

shane-tomlinson added a commit that referenced this issue Feb 1, 2012

Fixing the complete registration flow when the browser the user compl…
…etes registration is different from the one they started at.

* in check_registration.js, the "auth" message has been changed to "authenticate"
* in user.js, when the registration poll completes, set the "known" field of the address in the addressInfo cache to "true"

issue #1026
Member

jrgm commented Feb 1, 2012

verified flow above, with osx safari 5.1.2, opera 11.6, FF 10, Chrome 16. Also went through adding an email to the
first account. Moving on to winxp/{ie8,FF10,Chrome16,safari,opera}.

Member

jrgm commented Feb 1, 2012

verified flow above, with winxp safari 5.1.2, opera 11.61, FF 10, Chrome 16, IE8

Member

jrgm commented Feb 1, 2012

verified flow above on stage, with win7/32bit safari 5.1.2, opera 11.61, FF 10/11/12, Chrome 16, IE9

Member

jrgm commented Feb 1, 2012

verified flow above on stage, with ubuntu 11.0 for opera 11.61, FF 10/11/12, Chrome 16
Trying android if the network here works.

Contributor

jbonacci commented Feb 1, 2012

Mac (Safari) to iOS5 (Safari) and iOS5 to Mac seems to work fine.
Safari and Dolphin on iOS5 also works.

Contributor

jbonacci commented Feb 2, 2012

VM to VM works as well (not that anybody outside of QA would ever do this...)

Tomorrow morning I will do some Android 2.x, 3.x, and 4.x testing:
Stock browser + FF/Opera Mobile
Stock browser + desktop browser

Contributor

jbonacci commented Feb 2, 2012

Verified the following combinations across various OS, platforms, and browsers:
Desktop to desktop browser support
Desktop to mobile browser support
Mobile to desktop browser support
Mobile to mobile browser support

fetep pushed a commit to fetep/browserid that referenced this issue Feb 3, 2012

Fixing the complete registration flow when the browser the user compl…
…etes registration is different from the one they started at.

* in check_registration.js, the "auth" message has been changed to "authenticate"
* in user.js, when the registration poll completes, set the "known" field of the address in the addressInfo cache to "true"

closes #1026, closes #973
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.