This repository has been archived by the owner. It is now read-only.

CSS should support RTL locales #1066

Closed
ozten opened this Issue Feb 7, 2012 · 6 comments

Comments

Projects
None yet
6 participants
@ozten
Member

ozten commented Feb 7, 2012

With Issue 1065, we have our first right to left (RTL) language 'he'.

Most languages are left to right (LTR) such as English. On RTL locales, we want the entire page design to be mirrored.

We put the following in the HTML to trigger the CSS:

<html lang='he' dir='rtl'>

To see how this works, compare https://addons.mozilla.org/en-US/firefox/ to https://addons.mozilla.org/h/firefox/

Notice the entire page layout is flipped. en-US has Secondary Navigation on the left, he has it on the right... etc.

We need additional CSS code to supports RTL layout.

@ozten is happy to mentor new contributors in fixing this issue.

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Feb 8, 2012

Member

@skinny97214 - What do you think about removing the left to right arrow slide? It really offers no benefit to the user besides a bit of eye candy.

Member

shane-tomlinson commented Feb 8, 2012

@skinny97214 - What do you think about removing the left to right arrow slide? It really offers no benefit to the user besides a bit of eye candy.

@skinny97214

This comment has been minimized.

Show comment
Hide comment
@skinny97214

skinny97214 Feb 8, 2012

I'd like to keep it, especially if we can use it in place of a spinner to indicate progress. Can we reverse it for RTL locales?

I'd like to keep it, especially if we can use it in place of a spinner to indicate progress. Can we reverse it for RTL locales?

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Feb 9, 2012

Member

@skinny97214 - we don't actually use it to indicate progress - it is only used to indicate "the process is done" - which delays the user signing in by a second or so. The slide effect cannot be done during key generation (which is the slow part that comes before it, for which we show a wait screen) because key generation is synchronous and does give up any processing time to do any UI updates.

Member

shane-tomlinson commented Feb 9, 2012

@skinny97214 - we don't actually use it to indicate progress - it is only used to indicate "the process is done" - which delays the user signing in by a second or so. The slide effect cannot be done during key generation (which is the slow part that comes before it, for which we show a wait screen) because key generation is synchronous and does give up any processing time to do any UI updates.

@jbonacci

This comment has been minimized.

Show comment
Hide comment
@jbonacci

jbonacci Mar 27, 2012

Contributor

Yes. Just verified this now that Hebrew is in Stage.
Text and fields align as expected (right-justified).
But, the animation runs RTL which causes a pretty ugly sign_in dialog (albeit very temporarily).

Contributor

jbonacci commented Mar 27, 2012

Yes. Just verified this now that Hebrew is in Stage.
Text and fields align as expected (right-justified).
But, the animation runs RTL which causes a pretty ugly sign_in dialog (albeit very temporarily).

@zaach

This comment has been minimized.

Show comment
Hide comment
@zaach

zaach Aug 2, 2012

Contributor

This is a more general case of #873

Contributor

zaach commented Aug 2, 2012

This is a more general case of #873

@callahad

This comment has been minimized.

Show comment
Hide comment
@callahad

callahad Oct 31, 2014

Member

Hi! To help us better focus, I'm "closing" all issues that have been open for more than six months. These have been tagged "cleanup-2014" so that we can go back and review them in the future.

For more information, check out this thread: http://thread.gmane.org/gmane.comp.mozilla.identity.devel/7394

If you believe this bug is still a major issue for you, please comment, submit a pull request, or discuss it on our mailing list: https://lists.mozilla.org/listinfo/dev-identity

Sorry for GitHub notification spam!

Member

callahad commented Oct 31, 2014

Hi! To help us better focus, I'm "closing" all issues that have been open for more than six months. These have been tagged "cleanup-2014" so that we can go back and review them in the future.

For more information, check out this thread: http://thread.gmane.org/gmane.comp.mozilla.identity.devel/7394

If you believe this bug is still a major issue for you, please comment, submit a pull request, or discuss it on our mailing list: https://lists.mozilla.org/listinfo/dev-identity

Sorry for GitHub notification spam!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.