Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

buttons that could be potentially slow should have a spinner #1093

Closed
skinny97214 opened this Issue · 4 comments

6 participants

@skinny97214
Owner

Especially for mobile, we need to signal that the button press was recorded.

@lloyd lloyd was assigned
@sawyerh

@shane-tomlinson - I've added styles and a loader.gif asset, but wasn't sure what buttons this should be applied to or which .js file to implement that functionality in. All that really needs done is to apply a loading class to the button

sawyerh@e7a3f01

@jrgm
Collaborator

spinner looks good in train-2012.07.06 when applied with dev tools. Leaving this issue open to actually make use of it where appropriate.

@seanmonstar seanmonstar closed this
@jrgm
Collaborator

Okay, I've been using current dev with PR GH-2214 on multiple desktop browsers and I do see the spinner appear when clicking through buttons. I'll get to mobile later. Offhand, with a fast browser on a reasonable speed connection, it's a bit of a distraction, but I'll let other folks kick the tires, and see if they think the same.

@jrgm
Collaborator

verified train-2012.08.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.