https://browserid.org/signup is broken #1429

Closed
lloyd opened this Issue Apr 12, 2012 · 3 comments

Projects

None yet

2 participants

@lloyd
Contributor
lloyd commented Apr 12, 2012

this is in production after the push of train-2012.03.28. the signup page on browserid.org doesn't work, as the call to stage_user includes a domain rather than an origin, which interacts poorly with our new input parameter checking on the stage_user call.

Further, an Internal Server Error is returned, rather than a clearer 40x error messages which describes what inputs were bad.

@lloyd lloyd was assigned Apr 12, 2012
@jbonacci
Contributor

Verified on Stage. This makes me angry. QA should have caught this. This was the one release where I did not try the Sign Up because there is so little traffic through here...

@lloyd lloyd added a commit that referenced this issue Apr 12, 2012
@lloyd lloyd return HTTP 400 (bad request) when site or email parameters are malfo…
…rmed, not 500 (internal server error). issue #1429 issue #1423
e44f49e
@lloyd lloyd added a commit that referenced this issue Apr 12, 2012
@lloyd lloyd on browserid.org, set origin in user.js to a proper origin. This was …
…breaking code that expected it to be an origin, like /signup which invokes the stage_user api, which now validates the 'site' parameter is a properly formed origin. issue #1429
b0ec22c
@lloyd lloyd added a commit that referenced this issue Apr 12, 2012
@lloyd lloyd on browserid.org, set origin in user.js to a proper origin. This was …
…breaking code that expected it to be an origin, like /signup which invokes the stage_user api, which now validates the 'site' parameter is a properly formed origin. issue #1429
8c65cd6
@lloyd lloyd added a commit that referenced this issue Apr 12, 2012
@lloyd lloyd return HTTP 400 (bad request) when site or email parameters are malfo…
…rmed, not 500 (internal server error). issue #1429 issue #1423
fb7395f
@lloyd lloyd added a commit that referenced this issue Apr 12, 2012
@lloyd lloyd on browserid.org, set origin in user.js to a proper origin. This was …
…breaking code that expected it to be an origin, like /signup which invokes the stage_user api, which now validates the 'site' parameter is a properly formed origin. issue #1429

Conflicts:

	resources/static/shared/user.js
bfdc5db
@lloyd lloyd added a commit that referenced this issue Apr 12, 2012
@lloyd lloyd return HTTP 400 (bad request) when site or email parameters are malfo…
…rmed, not 500 (internal server error). issue #1429 issue #1423
92fce38
@lloyd lloyd added a commit that referenced this issue Apr 12, 2012
@lloyd lloyd on browserid.org, set origin in user.js to a proper origin. This was …
…breaking code that expected it to be an origin, like /signup which invokes the stage_user api, which now validates the 'site' parameter is a properly formed origin. issue #1429

Conflicts:

	resources/static/shared/user.js
5867a11
@lloyd lloyd closed this Apr 12, 2012
@lloyd
Contributor
lloyd commented Apr 12, 2012

to be deployed today in 0.2012.03.28.7

@jbonacci
Contributor

Verified in Stage and in Prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment