Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

BrowserID Dialog is too wide to fit in iPad sheet #1517

Closed
stuartparmenter opened this Issue · 8 comments

7 participants

@stuartparmenter

These 3 screenshots should illustrate the problem:

https://farm8.staticflickr.com/7114/6973789998_64b798a955_b.jpg (landscape)
https://farm9.staticflickr.com/8009/6973790056_20c1d35ec9_b.jpg
https://farm8.staticflickr.com/7115/7119872735_10d81cc18d_b.jpg

Lloyd also asked that I try this page out to verify the page is getting the correct sizes from the web view, which it appears to be:
https://farm8.staticflickr.com/7259/6973815466_9189fc5e04_b.jpg

Right now, we load the dialog in full screen but it has a huge amount of whitespace and generally doesn't look very good.

@lloyd

@shane-tomlinson I worked with @sppavlov on this one, and have full context. This is for our mozilla homies. The key question is why do many sites render properly in this iOS popup thingy while we don't? Is there a simple CSS change we can make in order to correctly detect the size and at least get the dialog to understand the size of the window?

@lloyd

@sppavlov - @shane-tomlinson confirmed that this is going to be WAAAY easier if there's a sample ipad app for us. basically it's an app that shows a text box and a button. put a url in the text box, click the button, and it pops up the url in the preferred modal thingy that you guys wanna display the sign-in dialog in.

Any way you guys can assist with this?

@st3fan

@lloyd I'll build you something!

@jbonacci
Collaborator

+1 for sample app

@st3fan

Oops I don't think I ever sent an app your way. I create a super simple app at https://bitbucket.org/st3fan/foo-viewer It has a screen with a url and three buttons to open a browser that is 1) iPhone Size 2) iPad Size 3) iPad Modal Sheet Size.

You can run it in Xcode in the iPad simulator. Rotation works. Let me know if this is useful.

@jbonacci
Collaborator

@shane-tomlinson and @lloyd should we do a little session on this now that we have a sample app?
Also, I am wondering if this is a more general issue for all tablets...

@sawyerh sawyerh was assigned
@sawyerh sawyerh referenced this issue from a commit in sawyerh/browserid
Sawyer Hollenshead Fix for issue #1517 - BrowserID Dialog overflowing 274e178
@sawyerh

@lloyd / @shane-tomlinson - This is being caused because the site is using the device width rather than the iOS popup window's width. Removing width=device-width from the viewport meta tag seems to fix the issue — I don't believe this breaks anything since we're setting the initial-scale and minimum-scale.

@lloyd lloyd referenced this issue from a commit
Sawyer Hollenshead hotfix dialog overflow in train-2012.06.22 - issue #1517 40e321f
@csuciu
Collaborator

Verified as fixed in Stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.