This repository has been archived by the owner. It is now read-only.

assertions passed to RP are showing as invalid #457

Closed
shane-tomlinson opened this Issue Oct 18, 2011 · 4 comments

Comments

Projects
None yet
3 participants
@shane-tomlinson
Member

shane-tomlinson commented Oct 18, 2011

This occurs in both dev and local.

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Oct 18, 2011

Member

in jws.js->verify, I added two console messages to check the verification steps. verify is being called twice, the first time both sig_verification and payload_verification are true, the second time, sig_verification is true, payload_verification is false. What would this be caused by?

Member

shane-tomlinson commented Oct 18, 2011

in jws.js->verify, I added two console messages to check the verification steps. verify is being called twice, the first time both sig_verification and payload_verification are true, the second time, sig_verification is true, payload_verification is false. What would this be caused by?

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Oct 18, 2011

Member

When I look in jwt.js->verifyPayload, "this.expires.valuesOf()" is returning NaN

Member

shane-tomlinson commented Oct 18, 2011

When I look in jwt.js->verifyPayload, "this.expires.valuesOf()" is returning NaN

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Oct 18, 2011

Member

in browserid/static/dialog/resources/user.js, if I go back to the old way of creating the token with the serverTime as the expiration, everything is kosher.

Member

shane-tomlinson commented Oct 18, 2011

in browserid/static/dialog/resources/user.js, if I go back to the old way of creating the token with the serverTime as the expiration, everything is kosher.

shane-tomlinson added a commit that referenced this issue Oct 18, 2011

Fixing a problem where the expiration date for the assertions was bei…
…ng calculated incorrectly.

Adding basic assertion tests to make sure all of the necessary parts are there and that the expiration date is actually a date.

issue #457

@lloyd lloyd closed this in 89a8231 Oct 19, 2011

@jbonacci

This comment has been minimized.

Show comment
Hide comment
@jbonacci

jbonacci Oct 26, 2011

Contributor

No verification testing needed by QA.

Contributor

jbonacci commented Oct 26, 2011

No verification testing needed by QA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.