This repository has been archived by the owner. It is now read-only.

break include.js into distinct components (for testing), combine in build script #483

Closed
shane-tomlinson opened this Issue Oct 25, 2011 · 6 comments

Comments

Projects
None yet
4 participants
@shane-tomlinson
Member

shane-tomlinson commented Oct 25, 2011

This is to facilitate unit testing.

@ghost ghost assigned shane-tomlinson Oct 25, 2011

@ianb

This comment has been minimized.

Show comment
Hide comment
@ianb

ianb Oct 25, 2011

Member

FWIW, here's what I use to include the JSChannel code into OWA's include.js: https://github.com/mozilla/openwebapps/blob/develop/site/tools/inline_code.py

(though I check in the result)

Member

ianb commented Oct 25, 2011

FWIW, here's what I use to include the JSChannel code into OWA's include.js: https://github.com/mozilla/openwebapps/blob/develop/site/tools/inline_code.py

(though I check in the result)

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson
Member

shane-tomlinson commented Oct 28, 2011

thanks @ianb

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Jun 14, 2012

Member

Closing as won't fix.

Member

shane-tomlinson commented Jun 14, 2012

Closing as won't fix.

@jbonacci

This comment has been minimized.

Show comment
Hide comment
@jbonacci

jbonacci Jul 19, 2012

Contributor

Verifying as a won't fix .

Contributor

jbonacci commented Jul 19, 2012

Verifying as a won't fix .

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Feb 27, 2013

Member

Re-opening with @callahad's push to make this happen.

Member

shane-tomlinson commented Feb 27, 2013

Re-opening with @callahad's push to make this happen.

@callahad

This comment has been minimized.

Show comment
Hide comment
@callahad

callahad Feb 27, 2013

Member

Closing back down -- include.js is now broken out into its constituent components and combined at build time. We just have to do some cleaning to make it awesome...

Member

callahad commented Feb 27, 2013

Closing back down -- include.js is now broken out into its constituent components and combined at build time. We just have to do some cleaning to make it awesome...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.