This repository has been archived by the owner. It is now read-only.

relay.js->browserid_relay is called twice whenever assertion is generated #489

Closed
shane-tomlinson opened this Issue Oct 26, 2011 · 3 comments

Comments

Projects
None yet
2 participants
@shane-tomlinson
Member

shane-tomlinson commented Oct 26, 2011

This is because when the first success message comes back, the RP attempts to close the window, which causes browserid_relay to be called a second time.

In dialog_controller.js, when an assertion is generated, setting self.onsuccess to undefined or null would fix this.

@ghost ghost assigned shane-tomlinson Oct 26, 2011

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Oct 26, 2011

Member

After the hack for #486, this is no longer replicable. Will verify again once that is fixed.

Member

shane-tomlinson commented Oct 26, 2011

After the hack for #486, this is no longer replicable. Will verify again once that is fixed.

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Oct 28, 2011

Member

Closing, this is no longer an issue.

Member

shane-tomlinson commented Oct 28, 2011

Closing, this is no longer an issue.

@jbonacci

This comment has been minimized.

Show comment
Hide comment
@jbonacci

jbonacci Dec 30, 2011

Contributor

Good. Marking as verified.

Contributor

jbonacci commented Dec 30, 2011

Good. Marking as verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.