This repository has been archived by the owner. It is now read-only.

get include.js takes 832ms to complete #742

Closed
Marlena opened this Issue Dec 12, 2011 · 11 comments

Comments

Projects
None yet
8 participants
@Marlena

Marlena commented Dec 12, 2011

Initially this looked like an intermittently occurring problem with writing an addon review. I now think it happens when someone changes their email for browser id.

  1. Open amo while logged into browserid as marlena.compton
  2. Logged into browser id with amo.testing
  3. searched for adblock plus
  4. clicked write review
  5. wrote the review and was redirected to this page
    https://addons-dev.allizom.org/en-US/firefox/addon/adblock-plus/reviews/add
  6. added a title and star
  7. clicked "submit review"
  8. The page hangs for a while after clicking submit the review
    https://skitch.com/marlenacompton/gxi9f/add-a-review-for-adblock-plus-add-ons-for-firefox

So I opened firebug to get more info about the request:
https://skitch.com/marlenacompton/gxsyk/while-waiting

Here's info from after the page completed. include.js took 832ms to load:
https://skitch.com/marlenacompton/gxsyh/adblock-plus-reviews-add-ons-for-firefox

Link to the old bugzilla bug. https://bugzilla.mozilla.org/show_bug.cgi?id=708970

@Marlena

This comment has been minimized.

Show comment
Hide comment
@Marlena

Marlena Dec 12, 2011

This screenshot has a bit more information about the timeline of the request: https://skitch.com/marlenacompton/gx296/includejsrequest

Marlena commented Dec 12, 2011

This screenshot has a bit more information about the timeline of the request: https://skitch.com/marlenacompton/gx296/includejsrequest

@ghost ghost assigned vmunix Dec 15, 2011

@lloyd

This comment has been minimized.

Show comment
Hide comment
@lloyd

lloyd Dec 15, 2011

Contributor

vmunix can we get worldwide monitoring of include.js response times?

Contributor

lloyd commented Dec 15, 2011

vmunix can we get worldwide monitoring of include.js response times?

@vmunix

This comment has been minimized.

Show comment
Hide comment
@vmunix

vmunix Dec 15, 2011

Member

yes, yes we can.

Member

vmunix commented Dec 15, 2011

yes, yes we can.

@vmunix

This comment has been minimized.

Show comment
Hide comment
@vmunix

vmunix Dec 15, 2011

Member

Setting up Watchmouse monitoring of https://browserid.org/include.js explicitly. Will report back once we have some data collected.

Member

vmunix commented Dec 15, 2011

Setting up Watchmouse monitoring of https://browserid.org/include.js explicitly. Will report back once we have some data collected.

@stephendonner

This comment has been minimized.

Show comment
Hide comment
@stephendonner

stephendonner Jan 20, 2012

I've seen this take as long as 13 seconds, while debugging why our Selenium tests are timing out. Is there any hope of putting this and other assets on a CDN?

I've seen this take as long as 13 seconds, while debugging why our Selenium tests are timing out. Is there any hope of putting this and other assets on a CDN?

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Jun 27, 2012

Member

@vmunix - do we have any monitoring on this now?

Member

shane-tomlinson commented Jun 27, 2012

@vmunix - do we have any monitoring on this now?

@callahad callahad closed this Feb 26, 2013

@callahad callahad reopened this Feb 26, 2013

@callahad

This comment has been minimized.

Show comment
Hide comment
@callahad

callahad Feb 26, 2013

Member

Is this still an issue? @gene1wood does ops have a plan for our move to AWS that would let us go ahead and close this?

(Whoops, didn't mean to close just then.)

Member

callahad commented Feb 26, 2013

Is this still an issue? @gene1wood does ops have a plan for our move to AWS that would let us go ahead and close this?

(Whoops, didn't mean to close just then.)

@gene1wood

This comment has been minimized.

Show comment
Hide comment
@gene1wood

gene1wood Feb 27, 2013

Member

@callahad Do you mean do we have a plan to ameliorate the response time or to monitor include.js once we're running out of AWS?

Member

gene1wood commented Feb 27, 2013

@callahad Do you mean do we have a plan to ameliorate the response time or to monitor include.js once we're running out of AWS?

@callahad

This comment has been minimized.

Show comment
Hide comment
@callahad

callahad Feb 27, 2013

Member

@gene1wood Just interested in the monitoring bit right now.

Member

callahad commented Feb 27, 2013

@gene1wood Just interested in the monitoring bit right now.

@gene1wood

This comment has been minimized.

Show comment
Hide comment
@gene1wood

gene1wood Feb 27, 2013

Member

I don't have any specific plan to change our monitoring of include.js in relation to the AWS move. We can establish whatever monitoring is useful either now or after the move.

Member

gene1wood commented Feb 27, 2013

I don't have any specific plan to change our monitoring of include.js in relation to the AWS move. We can establish whatever monitoring is useful either now or after the move.

@jedp

This comment has been minimized.

Show comment
Hide comment
@jedp

jedp Jul 11, 2013

Contributor

We have a number of specific bugs filed in type:performance. Let's pursue those and bring down load times, especially for mobile.

Contributor

jedp commented Jul 11, 2013

We have a number of specific bugs filed in type:performance. Let's pursue those and bring down load times, especially for mobile.

@jedp jedp closed this Jul 11, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.