Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

cancel forgot password is not working on required email flow. #754

Closed
shane-tomlinson opened this Issue · 6 comments

4 participants

Shane Tomlinson jbonacci Lloyd Hilaiel John Morrison
Shane Tomlinson
Collaborator

As this is a regression, marking 5 stars.

Shane Tomlinson
Collaborator

Steps to reproduce

1) go to diresworb.org, log out.
2) go to beta.myfavoriteshow.org, enter in one of your already registered email addresses.
3) click buttons to get browserid dialog.
4) click "forgot password"
5) click "cancel" - oops, nothing happens!

Shane Tomlinson
Collaborator

@lloyd - I was able to cherry pick the above commit into both beta and prod to fix the problem.

jbonacci
Collaborator

Verified against old Prod. UI flows work as expected.

Details:
Testing HotFix on browserid.org and myfavoriteshow.org.

Cancelling Sign-In to myfavoriteshow.org gives the proper "help" message in the RP:
"Oops! looks like there was some trouble getting you added! Please try again below."

Entering/cancelling the "forgot your password?" flow now works as expected.

Normal sign-in path with current account is working.

Normal sign-in path with new account is working.

The "forgot your passowrd?" normal flow works as expected.

Only known issue:
If you sign out of BrowserID and refresh myfavoriteshow.org, the email field should clear out, but it stays "populated" with the last used email for that RP.

jbonacci
Collaborator

Will do a final verify in Stage on the next train.

Lloyd Hilaiel

now this issue is really closed. merged into current production (train-2011.12.01) and beta (train-2011.12.08)

John Morrison
Collaborator

Verified on stage environment (beta.myfavoriteshow.org,diresworb.org):
Windows XP: (Safari 5.1.2, Firefox 9.0.1, Chrome 16, Opera 11.6, IE 8)
Windows 7 32-bit: (Safari 5.1.2, Firefox 9.0.1, Chrome 16, Opera 11.6, IE 9)
OSX 10.7.2: (Safari 5.1.2, Firefox 9.0.1, Chrome 16, Opera 11.6)
Ubuntu 11.10: (Firefox 9.0.1, Chrome 16)

Change password link works, and cancelling out of that dialog returns
to previous email/password entry screen. Cancelling all the way out
of the dialog shows the "Oops! looks like ..." message in beta.myfshow.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.