This repository has been archived by the owner. It is now read-only.

Sign-in failure using Google Chrome Frame #796

Closed
hwinkler opened this Issue Dec 22, 2011 · 14 comments

Comments

Projects
None yet
6 participants
@hwinkler

You can repro this on myfavoritebeer
Steps to repro:

  1. On Windows, install GCF http://www.google.com/chromeframe
  2. In IE, force GCF to load myfavoritebeer.org; enter into the address bar: gcf:http://myfavoritebeer.org/
  3. Click "Sign in"

EB: Sign-in dialog for Browserid
AB: Error page "Relay frame could not be found". This error page, notice, is rendered by IE, not by GCF.

I think the source of the problem is failure to communicate across iframe boundary. This is a known limitation of GCF.

I suspect the solution would be to use CORS headers to invoke the production.js script?

@hwinkler

This comment has been minimized.

Show comment
Hide comment
@hwinkler

hwinkler Jan 17, 2012

I think this approach might be useful for the GCF case. It uses an <object> tag to simulate an iframe. http://src.chromium.org/svn/branches/472/src/chrome_frame/test/data/postmessage_basic_host.html

I think this approach might be useful for the GCF case. It uses an <object> tag to simulate an iframe. http://src.chromium.org/svn/branches/472/src/chrome_frame/test/data/postmessage_basic_host.html

@hwinkler

This comment has been minimized.

Show comment
Hide comment

hwinkler commented Feb 4, 2012

Hullo?

@ghost ghost assigned shane-tomlinson Mar 8, 2012

@jbonacci

This comment has been minimized.

Show comment
Hide comment
@jbonacci

jbonacci Jun 26, 2012

Contributor

Hullo indeed. This has gone stale. Adding a couple more stars since it came up in the dev-identity email list this week.

Contributor

jbonacci commented Jun 26, 2012

Hullo indeed. This has gone stale. Adding a couple more stars since it came up in the dev-identity email list this week.

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Jun 27, 2012

Member

@jbonacci - I'm not sure this is really a 4*, but I agree that we should investigate the problem and what possible solutions exist. What percentage of the market is using GCF? Is it substantial enough to consider it an A-Grade browser? Is GCF more popular than other unsupported browsers like Dolphin? Is it worth putting GCF over other features/issues or is it a "nice to have"?

Member

shane-tomlinson commented Jun 27, 2012

@jbonacci - I'm not sure this is really a 4*, but I agree that we should investigate the problem and what possible solutions exist. What percentage of the market is using GCF? Is it substantial enough to consider it an A-Grade browser? Is GCF more popular than other unsupported browsers like Dolphin? Is it worth putting GCF over other features/issues or is it a "nice to have"?

@hwinkler

This comment has been minimized.

Show comment
Hide comment
@hwinkler

hwinkler Jun 27, 2012

When you're investigating usage statistics, keep in mind that there's a metric you need to consider with GCF that doesn't apply to Dolphin and other browsers: how many web sites offer a GCF header or meta tag? People don't install GCF out of thin air and browse the web with it. They encounter web sites that suggest or require that they install it.

In our case we require IE users install GCF because it's a WebGL site. We cannot use BrowserID because of that.

Put another way, any web site that exposes WebGl has to choose between supporting BrowserID and IE.

When you're investigating usage statistics, keep in mind that there's a metric you need to consider with GCF that doesn't apply to Dolphin and other browsers: how many web sites offer a GCF header or meta tag? People don't install GCF out of thin air and browse the web with it. They encounter web sites that suggest or require that they install it.

In our case we require IE users install GCF because it's a WebGL site. We cannot use BrowserID because of that.

Put another way, any web site that exposes WebGl has to choose between supporting BrowserID and IE.

@ghost ghost assigned seanmonstar Jun 28, 2012

@seanmonstar

This comment has been minimized.

Show comment
Hide comment
@seanmonstar

seanmonstar Jun 28, 2012

Member

Is this not simply a case of the originating page (myfavoritebeer.org) being from GCF, but the dialog rendering with plain IE (since it's a new window, without the gcf: prefix), and so they can't communicate?

Member

seanmonstar commented Jun 28, 2012

Is this not simply a case of the originating page (myfavoritebeer.org) being from GCF, but the dialog rendering with plain IE (since it's a new window, without the gcf: prefix), and so they can't communicate?

@seanmonstar

This comment has been minimized.

Show comment
Hide comment
@seanmonstar

seanmonstar Jul 11, 2012

Member

So, I've confirmed that I can talk to popups using the method from the link above.

@lloyd To fix this would require a patch to WinChan. It would need to check for GCF, and if so, use a relay iframe (different than normal IE) that would open the popup, and then the iframe becomes the mediator. So, RP -> iframe -> dialog, and then dialog -> iframe -> RP. I've got a half working implementation, and can flesh it out if it's worth it to contain this much complexity.

Of course, IE doesn't work using this method, so both kinds of relaying would need to exist.

Member

seanmonstar commented Jul 11, 2012

So, I've confirmed that I can talk to popups using the method from the link above.

@lloyd To fix this would require a patch to WinChan. It would need to check for GCF, and if so, use a relay iframe (different than normal IE) that would open the popup, and then the iframe becomes the mediator. So, RP -> iframe -> dialog, and then dialog -> iframe -> RP. I've got a half working implementation, and can flesh it out if it's worth it to contain this much complexity.

Of course, IE doesn't work using this method, so both kinds of relaying would need to exist.

@seanmonstar

This comment has been minimized.

Show comment
Hide comment
@seanmonstar

seanmonstar Jul 11, 2012

Member

if I didn't make it clear, the difference is that for GCF the iframe needs to open the window itself , and the popup doesn't need to search for the relay; the popup just posts messages, oblivious to the cruel world it is in.

Member

seanmonstar commented Jul 11, 2012

if I didn't make it clear, the difference is that for GCF the iframe needs to open the window itself , and the popup doesn't need to search for the relay; the popup just posts messages, oblivious to the cruel world it is in.

@bryandonnovan

This comment has been minimized.

Show comment
Hide comment
@bryandonnovan

bryandonnovan Jul 22, 2012

My 2 cents: I would argue that supporting chrome frame is worth the added complexity.

My 2 cents: I would argue that supporting chrome frame is worth the added complexity.

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Jul 1, 2013

Member

Since Google is retiring Google Chrome Frame [http://blog.chromium.org/2013/06/retiring-chrome-frame.html], I do not believe it makes sense to add support for it. I am all for a non-popup flow, but adding support for GCF should not be a goal. @seanmonstar?

Member

shane-tomlinson commented Jul 1, 2013

Since Google is retiring Google Chrome Frame [http://blog.chromium.org/2013/06/retiring-chrome-frame.html], I do not believe it makes sense to add support for it. I am all for a non-popup flow, but adding support for GCF should not be a goal. @seanmonstar?

@callahad

This comment has been minimized.

Show comment
Hide comment
@callahad

callahad Jul 1, 2013

Member

I'm fine with GCF being an explicit non-goal.

Member

callahad commented Jul 1, 2013

I'm fine with GCF being an explicit non-goal.

@seanmonstar

This comment has been minimized.

Show comment
Hide comment
@seanmonstar

seanmonstar Jul 1, 2013

Member

Sounds good to me.

Member

seanmonstar commented Jul 1, 2013

Sounds good to me.

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Jul 1, 2013

Member

Closing.

Member

shane-tomlinson commented Jul 1, 2013

Closing.

zaach pushed a commit to zaach/123done that referenced this issue Apr 2, 2014

Leave Chrome Frame disabled because it won't work
Chrome Frame is not currently supported by Persona:

  mozilla/persona#796
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.