This repository has been archived by the owner. It is now read-only.

repair internal.get API - it should return a bare assertion represented ... #1409

Merged
merged 2 commits into from Apr 11, 2012

Conversation

Projects
None yet
4 participants
Contributor

lloyd commented Apr 9, 2012

...as a string, not an object - issue #1395

Contributor

lloyd commented Apr 9, 2012

@st3fan - can you please verify that this fixes the internal API for you. Just...

... replace browserid.org with issue1395.hacksign.in for both where you include javascript resources and where you send assertions for verification.

depending on your report, we'll merge this or not.

Member

st3fan commented Apr 10, 2012

@lloyd I cannot test this on iOS from a UIWebView because iOS complains about the certificate for *.hacksign.in. Maybe the intermediate certificate is missing on your server?

Contributor

lloyd commented Apr 10, 2012

@st3fan try again please? I think I fixed the SSL issue.

Contributor

benadida commented Apr 11, 2012

on code alone, assuming @st3fan confirms, r+.

Member

shane-tomlinson commented Apr 11, 2012

@lloyd - When the old API is officially completely removed, we should clean up the unit tests for the internal api, there are a lot of tests with the "silent: true" option.

Member

st3fan commented Apr 11, 2012

@lloyd I tested against issue1395.hacksign.in and that works ok.

Contributor

lloyd commented Apr 11, 2012

given @benadida's review, and @st3fan's confirmation, I'm merging this.

lloyd added a commit that referenced this pull request Apr 11, 2012

Merge pull request #1409 from mozilla/issue1395
repair internal.get API - it should return a bare assertion represented ...  closes #1395

@lloyd lloyd merged commit 9b39d57 into dev Apr 11, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.