Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

issue 1464 ie exception check registration #1490

Merged
merged 1 commit into from Apr 24, 2012

Conversation

Projects
None yet
2 participants
Member

shane-tomlinson commented Apr 24, 2012

Fix the broken test in check_registration. It was starting the registration check twice, meaning there were two concurrent polls happening.

I am submitting this pull request against the current beta because that is where @jrgm reported the problem. A hotfix is not needed because this is not a user facing problem.

issue #1464

@shane-tomlinson shane-tomlinson Fix the broken test in check_registration. It was starting the regist…
…ration check twice, meaning there were two concurrent polls happening.

issue #1464
1172a5b
Contributor

benadida commented Apr 24, 2012

@shane-tomlinson if this is not a user-facing problem, maybe it's worth rebasing this against dev and waiting 2 weeks to release? No need to increase risk on this week's production release, I think.

Member

shane-tomlinson commented Apr 24, 2012

@benadida - I created this patch against the 2012.04.11 train because @jrgm has been checking out the code and running the tests in a local environment. Doing so with the 2012.04.11 train will continue to throw the exceptions. The merge can wait for the next train, but I think this is a low risk merge because it modifies the unit tests and none of the user facing code.

Contributor

benadida commented Apr 24, 2012

oh, I should have looked at the diff first. r+.

@benadida benadida added a commit that referenced this pull request Apr 24, 2012

@benadida benadida Merge pull request #1490 from mozilla/issue_1464_ie_exception_check_r…
…egistration

issue 1464 ie exception check registration
a2eea06

@benadida benadida merged commit a2eea06 into train-2012.04.11 Apr 24, 2012

Member

shane-tomlinson commented Apr 24, 2012

Thanks @benadida. This does not need backported to dev as dev took a different approach to this test that already had it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment